From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Fam Zheng <famz@redhat.com>,
qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/4] block: fix 'savevm' hang with -object iothread
Date: Tue, 30 May 2017 14:52:56 +0100 [thread overview]
Message-ID: <20170530135256.GA3592@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170522135704.842-1-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
On Mon, May 22, 2017 at 02:57:00PM +0100, Stefan Hajnoczi wrote:
> v3:
> * Add missing bdrv_drain_all_end() in error code paths [Kevin]
> v2:
> * New patch to use bdrv_drain_all_begin/end() in savevm/loadvm [Kevin]
> (All other patches unchanged)
>
> The 'savevm' command hangs when -object iothread is used. See patches for
> details, but basically the vmstate read/write code didn't conform to the latest
> block layer locking rules.
>
> Stefan Hajnoczi (4):
> block: count bdrv_co_rw_vmstate() requests
> block: use BDRV_POLL_WHILE() in bdrv_rw_vmstate()
> migration: avoid recursive AioContext locking in save_vmstate()
> migration: use bdrv_drain_all_begin/end() instead bdrv_drain_all()
>
> block/io.c | 21 +++++++++++++--------
> migration/savevm.c | 30 ++++++++++++++++++++++++++----
> 2 files changed, 39 insertions(+), 12 deletions(-)
Ping
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-05-30 13:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 13:57 [Qemu-devel] [PATCH v3 0/4] block: fix 'savevm' hang with -object iothread Stefan Hajnoczi
2017-05-22 13:57 ` [Qemu-devel] [PATCH v3 1/4] block: count bdrv_co_rw_vmstate() requests Stefan Hajnoczi
2017-05-22 13:57 ` [Qemu-devel] [PATCH v3 2/4] block: use BDRV_POLL_WHILE() in bdrv_rw_vmstate() Stefan Hajnoczi
2017-05-22 13:57 ` [Qemu-devel] [PATCH v3 3/4] migration: avoid recursive AioContext locking in save_vmstate() Stefan Hajnoczi
2017-06-14 10:10 ` Pavel Butsykin
2017-06-14 13:15 ` Pavel Butsykin
2017-06-14 14:43 ` Kevin Wolf
2017-06-15 13:33 ` Pavel Butsykin
2017-05-22 13:57 ` [Qemu-devel] [PATCH v3 4/4] migration: use bdrv_drain_all_begin/end() instead bdrv_drain_all() Stefan Hajnoczi
2017-05-22 17:40 ` Eric Blake
2017-05-30 13:52 ` Stefan Hajnoczi [this message]
2017-06-12 13:47 ` [Qemu-devel] [Qemu-block] [PATCH v3 0/4] block: fix 'savevm' hang with -object iothread Stefan Hajnoczi
2017-06-13 12:14 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530135256.GA3592@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).