From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFih8-0004Q8-C3 for qemu-devel@nongnu.org; Tue, 30 May 2017 11:04:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFih5-00040u-7t for qemu-devel@nongnu.org; Tue, 30 May 2017 11:04:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55082) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dFih5-00040h-1i for qemu-devel@nongnu.org; Tue, 30 May 2017 11:04:23 -0400 Date: Tue, 30 May 2017 16:04:22 +0100 From: "Daniel P. Berrange" Message-ID: <20170530150422.GR21566@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170530143052.165002-1-vsementsov@virtuozzo.com> <20170530143052.165002-12-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170530143052.165002-12-vsementsov@virtuozzo.com> Subject: Re: [Qemu-devel] [PATCH 11/19] io/channel-socket: qio_channel_socket_writev handle EPIPE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, den@openvz.org On Tue, May 30, 2017 at 05:30:44PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Return QIO_CHANNEL_ERR_EPIPE on EPIPE, we will need it to improve error > path in nbd server. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/io/channel.h | 1 + > io/channel-socket.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/io/channel.h b/include/io/channel.h > index 5d48906998..5529c2da31 100644 > --- a/include/io/channel.h > +++ b/include/io/channel.h > @@ -38,6 +38,7 @@ typedef struct QIOChannel QIOChannel; > typedef struct QIOChannelClass QIOChannelClass; > > #define QIO_CHANNEL_ERR_BLOCK -2 > +#define QIO_CHANNEL_ERR_EPIPE -3 > > typedef enum QIOChannelFeature QIOChannelFeature; > > diff --git a/io/channel-socket.c b/io/channel-socket.c > index 53386b7ba3..50f9f966c6 100644 > --- a/io/channel-socket.c > +++ b/io/channel-socket.c > @@ -542,7 +542,7 @@ static ssize_t qio_channel_socket_writev(QIOChannel *ioc, > } > error_setg_errno(errp, errno, > "Unable to write to socket"); > - return -1; > + return errno == EPIPE ? QIO_CHANNEL_ERR_EPIPE : -1; > } > return ret; Ewwww, no. We don't want to go down the road of special casing further errno values for every error scenario. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|