From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFyyA-0000HB-8w for qemu-devel@nongnu.org; Wed, 31 May 2017 04:27:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFyy5-0004vh-B2 for qemu-devel@nongnu.org; Wed, 31 May 2017 04:27:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37248) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dFyy5-0004vV-4T for qemu-devel@nongnu.org; Wed, 31 May 2017 04:27:01 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 01E5A81250 for ; Wed, 31 May 2017 08:27:00 +0000 (UTC) Date: Wed, 31 May 2017 16:26:51 +0800 From: Peter Xu Message-ID: <20170531082651.GJ14845@pxdev.xzpeter.org> References: <1494854073-19898-1-git-send-email-peterx@redhat.com> <87k2506ltg.fsf@dusky.pond.sub.org> <20170529101331.GA14845@pxdev.xzpeter.org> <87d1ar504h.fsf@dusky.pond.sub.org> <13985c6d-d24a-ac50-2708-fc3b9cc64acd@redhat.com> <87h902l8qd.fsf@dusky.pond.sub.org> <6a6a91cc-7ea1-2b45-a4bd-31aa3cfef917@redhat.com> <20170531070346.GE14845@pxdev.xzpeter.org> <1633113774.3648008.1496216414543.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1633113774.3648008.1496216414543.JavaMail.zimbra@redhat.com> Subject: Re: [Qemu-devel] [PATCH] msi: remove return code for msi_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Markus Armbruster , Marcel Apfelbaum , qemu-devel@nongnu.org, "Michael S . Tsirkin" On Wed, May 31, 2017 at 03:40:14AM -0400, Paolo Bonzini wrote: > > > > >> I'd prefer to remove msi_nonbroken completely if we don't > > > >> know where the problem is. > > > > > > > > So you're proposing to (1) remove msi_nonbroken, (2) see which boards > > > > burst into flames, and (3) fix them, or perhaps add a less wrong stop > > > > gap msi_broken just for them? > > > > > > Yes, adding back msi_broken is one "git revert" away. > > > > Not sure whether I got the point here, but... Adding msi_broken is not > > a "git revert"? Since there is no msi_broken before, only > > msi_supported. > > Not exactly a "git revert", but pretty close since the logic for error reporting > is the same and those are the 100 lines your patch removes. The hard part is > finding which boards need it. Ok before I move on let's see whether this is what we want... - firstly, find all machine types: pxdev:qemu [edu-fix]# grep -R ".parent = TYPE_MACHINE" * | wc 49 196 2269 so now we have 49 kinds of machines. - rename msi_nonbroken into msi_broken, then: - x86/arm/spapr/s390 machines are the only ones that don't need to set msi_broken since they support MSI and have msi_nonbroken set, either in board init function or in irq chip init function - for all the rest of the machines, I should add "msi_broken" in its machine init() function. Is this really what we want? -- Peter Xu