qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com
Subject: [Qemu-devel] [PATCH v2 06/10] migration: Export tls.c functions in its own file
Date: Wed, 31 May 2017 12:35:05 +0200	[thread overview]
Message-ID: <20170531103509.22021-7-quintela@redhat.com> (raw)
In-Reply-To: <20170531103509.22021-1-quintela@redhat.com>

Just for the functions exported from tls.c.  Notice that we can't
remove the migration/migration.h include from tls.c because it access
directly MigrationState for the tls params.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 include/migration/migration.h | 10 ----------
 migration/channel.c           |  1 +
 migration/migration.c         |  1 -
 migration/tls.c               |  1 +
 migration/tls.h               | 34 ++++++++++++++++++++++++++++++++++
 5 files changed, 36 insertions(+), 11 deletions(-)
 create mode 100644 migration/tls.h

diff --git a/include/migration/migration.h b/include/migration/migration.h
index 9d311ed..29fda5b 100644
--- a/include/migration/migration.h
+++ b/include/migration/migration.h
@@ -18,7 +18,6 @@
 #include "qemu-common.h"
 #include "qemu/thread.h"
 #include "qemu/notify.h"
-#include "io/channel.h"
 #include "qapi-types.h"
 #include "exec/cpu-common.h"
 #include "qemu/coroutine_int.h"
@@ -152,15 +151,6 @@ void migration_fd_process_incoming(QEMUFile *f);
 
 void qemu_start_incoming_migration(const char *uri, Error **errp);
 
-void migration_tls_channel_process_incoming(MigrationState *s,
-                                            QIOChannel *ioc,
-                                            Error **errp);
-
-void migration_tls_channel_connect(MigrationState *s,
-                                   QIOChannel *ioc,
-                                   const char *hostname,
-                                   Error **errp);
-
 uint64_t migrate_max_downtime(void);
 
 void rdma_start_outgoing_migration(void *opaque, const char *host_port, Error **errp);
diff --git a/migration/channel.c b/migration/channel.c
index 2e78905cc..eae1d9e 100644
--- a/migration/channel.c
+++ b/migration/channel.c
@@ -12,6 +12,7 @@
 
 #include "qemu/osdep.h"
 #include "channel.h"
+#include "tls.h"
 #include "migration/migration.h"
 #include "qemu-file-channel.h"
 #include "trace.h"
diff --git a/migration/migration.c b/migration/migration.c
index f5140d2..6e11db2 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -43,7 +43,6 @@
 #include "exec/address-spaces.h"
 #include "exec/target_page.h"
 #include "io/channel-buffer.h"
-#include "io/channel-tls.h"
 #include "migration/colo.h"
 
 #define MAX_THROTTLE  (32 << 20)      /* Migration transfer speed throttling */
diff --git a/migration/tls.c b/migration/tls.c
index 34ad121..bae9aca 100644
--- a/migration/tls.c
+++ b/migration/tls.c
@@ -21,6 +21,7 @@
 #include "qemu/osdep.h"
 #include "channel.h"
 #include "migration/migration.h"
+#include "tls.h"
 #include "io/channel-tls.h"
 #include "crypto/tlscreds.h"
 #include "qemu/error-report.h"
diff --git a/migration/tls.h b/migration/tls.h
new file mode 100644
index 0000000..cdd7000
--- /dev/null
+++ b/migration/tls.h
@@ -0,0 +1,34 @@
+/*
+ * QEMU migration TLS support
+ *
+ * Copyright (c) 2015 Red Hat, Inc.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+#ifndef QEMU_MIGRATION_TLS_H
+#define QEMU_MIGRATION_TLS_H
+
+#include "io/channel.h"
+
+void migration_tls_channel_process_incoming(MigrationState *s,
+                                            QIOChannel *ioc,
+                                            Error **errp);
+
+void migration_tls_channel_connect(MigrationState *s,
+                                   QIOChannel *ioc,
+                                   const char *hostname,
+                                   Error **errp);
+#endif
-- 
2.9.4

  parent reply	other threads:[~2017-05-31 10:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31 10:34 [Qemu-devel] [PATCH v2 00/10] Another cleanup of includes Juan Quintela
2017-05-31 10:35 ` [Qemu-devel] [PATCH v2 01/10] migration: Remove unneeded includes of migration/vmstate.h Juan Quintela
2017-06-01 12:00   ` Dr. David Alan Gilbert
2017-06-01 12:03   ` Dr. David Alan Gilbert
2017-05-31 10:35 ` [Qemu-devel] [PATCH v2 02/10] migration: Split qemu-file.h Juan Quintela
2017-06-01 12:21   ` Dr. David Alan Gilbert
2017-06-01 15:19     ` Juan Quintela
2017-05-31 10:35 ` [Qemu-devel] [PATCH v2 03/10] migration: Export exec.c functions in its own file Juan Quintela
2017-06-01 12:28   ` Dr. David Alan Gilbert
2017-05-31 10:35 ` [Qemu-devel] [PATCH v2 04/10] migration: Export fd.c " Juan Quintela
2017-06-01 12:29   ` Dr. David Alan Gilbert
2017-05-31 10:35 ` [Qemu-devel] [PATCH v2 05/10] migration: Export socket.c " Juan Quintela
2017-06-01 12:37   ` Dr. David Alan Gilbert
2017-05-31 10:35 ` Juan Quintela [this message]
2017-06-01 12:41   ` [Qemu-devel] [PATCH v2 06/10] migration: Export tls.c " Dr. David Alan Gilbert
2017-06-01 15:20     ` Juan Quintela
2017-06-01 15:56       ` Dr. David Alan Gilbert
2017-05-31 10:35 ` [Qemu-devel] [PATCH v2 07/10] migration: Export rdma.c " Juan Quintela
2017-06-01 12:46   ` Dr. David Alan Gilbert
2017-06-01 15:22     ` Juan Quintela
2017-06-01 15:51       ` Dr. David Alan Gilbert
2017-05-31 10:35 ` [Qemu-devel] [PATCH v2 08/10] migration: Create include for migration snapshots Juan Quintela
2017-06-01 12:43   ` Dr. David Alan Gilbert
2017-05-31 10:35 ` [Qemu-devel] [PATCH v2 09/10] migration: Export ram.c functions in its own file Juan Quintela
2017-05-31 10:35 ` [Qemu-devel] [PATCH v2 10/10] migration: Move include/migration/block.h into migration/ Juan Quintela
2017-06-01 12:44   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170531103509.22021-7-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).