* [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: use STRIP variable in Makefile
@ 2017-05-31 13:09 Greg Kurz
2017-05-31 13:34 ` Laurent Vivier
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Greg Kurz @ 2017-05-31 13:09 UTC (permalink / raw)
To: qemu-devel
Cc: Cornelia Huck, Christian Borntraeger, Fam Zheng, Alexander Graf,
Philippe Mathieu-Daudé
The docker-run-test-build@debian-s390x-cross target fails with:
strip --strip-unneeded s390-ccw.elf -o s390-ccw.img
strip: Unable to recognise the format of the input file `s390-ccw.elf'
The configure script defines a STRIP makefile variable whose default
value is ${cross_prefix}strip. Let's use it.
We default to using the non-prefixed strip command in case --enable-debug
or --disable-strip was passed to configure during a regular build.
Signed-off-by: Greg Kurz <groug@kaod.org>
---
v2: - added default value
- no longer Cc: qemu-trivial as it turned out to be not that trivial
Philippe,
Please give your Reviewed-by again if you're okay with this change.
---
pc-bios/s390-ccw/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
index 79a46b67356f..fb88c13bc742 100644
--- a/pc-bios/s390-ccw/Makefile
+++ b/pc-bios/s390-ccw/Makefile
@@ -21,8 +21,10 @@ build-all: s390-ccw.img
s390-ccw.elf: $(OBJECTS)
$(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS),"BUILD","$(TARGET_DIR)$@")
+STRIP ?= strip
+
s390-ccw.img: s390-ccw.elf
- $(call quiet-command,strip --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
+ $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
$(OBJECTS): Makefile
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: use STRIP variable in Makefile
2017-05-31 13:09 [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: use STRIP variable in Makefile Greg Kurz
@ 2017-05-31 13:34 ` Laurent Vivier
2017-05-31 13:41 ` Fam Zheng
2017-05-31 13:50 ` Christian Borntraeger
2 siblings, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2017-05-31 13:34 UTC (permalink / raw)
To: Greg Kurz, qemu-devel
Cc: Cornelia Huck, Christian Borntraeger, Fam Zheng, Alexander Graf,
Philippe Mathieu-Daudé
On 31/05/2017 15:09, Greg Kurz wrote:
> The docker-run-test-build@debian-s390x-cross target fails with:
>
> strip --strip-unneeded s390-ccw.elf -o s390-ccw.img
> strip: Unable to recognise the format of the input file `s390-ccw.elf'
>
> The configure script defines a STRIP makefile variable whose default
> value is ${cross_prefix}strip. Let's use it.
>
> We default to using the non-prefixed strip command in case --enable-debug
> or --disable-strip was passed to configure during a regular build.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> v2: - added default value
> - no longer Cc: qemu-trivial as it turned out to be not that trivial
>
> Philippe,
>
> Please give your Reviewed-by again if you're okay with this change.
> ---
> pc-bios/s390-ccw/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
> index 79a46b67356f..fb88c13bc742 100644
> --- a/pc-bios/s390-ccw/Makefile
> +++ b/pc-bios/s390-ccw/Makefile
> @@ -21,8 +21,10 @@ build-all: s390-ccw.img
> s390-ccw.elf: $(OBJECTS)
> $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS),"BUILD","$(TARGET_DIR)$@")
>
> +STRIP ?= strip
> +
> s390-ccw.img: s390-ccw.elf
> - $(call quiet-command,strip --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
> + $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
>
> $(OBJECTS): Makefile
>
>
>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: use STRIP variable in Makefile
2017-05-31 13:09 [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: use STRIP variable in Makefile Greg Kurz
2017-05-31 13:34 ` Laurent Vivier
@ 2017-05-31 13:41 ` Fam Zheng
2017-05-31 13:50 ` Christian Borntraeger
2 siblings, 0 replies; 5+ messages in thread
From: Fam Zheng @ 2017-05-31 13:41 UTC (permalink / raw)
To: Greg Kurz
Cc: qemu-devel, Cornelia Huck, Christian Borntraeger, Alexander Graf,
Philippe Mathieu-Daudé
On Wed, 05/31 15:09, Greg Kurz wrote:
> The docker-run-test-build@debian-s390x-cross target fails with:
>
> strip --strip-unneeded s390-ccw.elf -o s390-ccw.img
> strip: Unable to recognise the format of the input file `s390-ccw.elf'
>
> The configure script defines a STRIP makefile variable whose default
> value is ${cross_prefix}strip. Let's use it.
>
> We default to using the non-prefixed strip command in case --enable-debug
> or --disable-strip was passed to configure during a regular build.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> v2: - added default value
> - no longer Cc: qemu-trivial as it turned out to be not that trivial
>
> Philippe,
>
> Please give your Reviewed-by again if you're okay with this change.
> ---
> pc-bios/s390-ccw/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
> index 79a46b67356f..fb88c13bc742 100644
> --- a/pc-bios/s390-ccw/Makefile
> +++ b/pc-bios/s390-ccw/Makefile
> @@ -21,8 +21,10 @@ build-all: s390-ccw.img
> s390-ccw.elf: $(OBJECTS)
> $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS),"BUILD","$(TARGET_DIR)$@")
>
> +STRIP ?= strip
> +
> s390-ccw.img: s390-ccw.elf
> - $(call quiet-command,strip --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
> + $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
>
> $(OBJECTS): Makefile
>
>
>
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: use STRIP variable in Makefile
2017-05-31 13:09 [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: use STRIP variable in Makefile Greg Kurz
2017-05-31 13:34 ` Laurent Vivier
2017-05-31 13:41 ` Fam Zheng
@ 2017-05-31 13:50 ` Christian Borntraeger
2017-05-31 13:58 ` Philippe Mathieu-Daudé
2 siblings, 1 reply; 5+ messages in thread
From: Christian Borntraeger @ 2017-05-31 13:50 UTC (permalink / raw)
To: Greg Kurz, qemu-devel
Cc: Cornelia Huck, Fam Zheng, Alexander Graf,
Philippe Mathieu-Daudé
On 05/31/2017 03:09 PM, Greg Kurz wrote:
> The docker-run-test-build@debian-s390x-cross target fails with:
>
> strip --strip-unneeded s390-ccw.elf -o s390-ccw.img
> strip: Unable to recognise the format of the input file `s390-ccw.elf'
>
> The configure script defines a STRIP makefile variable whose default
> value is ${cross_prefix}strip. Let's use it.
>
> We default to using the non-prefixed strip command in case --enable-debug
> or --disable-strip was passed to configure during a regular build.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> v2: - added default value
> - no longer Cc: qemu-trivial as it turned out to be not that trivial
>
> Philippe,
>
> Please give your Reviewed-by again if you're okay with this change.
> ---
> pc-bios/s390-ccw/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
> index 79a46b67356f..fb88c13bc742 100644
> --- a/pc-bios/s390-ccw/Makefile
> +++ b/pc-bios/s390-ccw/Makefile
> @@ -21,8 +21,10 @@ build-all: s390-ccw.img
> s390-ccw.elf: $(OBJECTS)
> $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS),"BUILD","$(TARGET_DIR)$@")
>
> +STRIP ?= strip
> +
> s390-ccw.img: s390-ccw.elf
> - $(call quiet-command,strip --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
> + $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
>
> $(OBJECTS): Makefile
>
>
applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: use STRIP variable in Makefile
2017-05-31 13:50 ` Christian Borntraeger
@ 2017-05-31 13:58 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-05-31 13:58 UTC (permalink / raw)
To: Christian Borntraeger, Greg Kurz, qemu-devel
Cc: Cornelia Huck, Fam Zheng, Alexander Graf
> On 05/31/2017 03:09 PM, Greg Kurz wrote:
>> The docker-run-test-build@debian-s390x-cross target fails with:
>>
>> strip --strip-unneeded s390-ccw.elf -o s390-ccw.img
>> strip: Unable to recognise the format of the input file `s390-ccw.elf'
>>
>> The configure script defines a STRIP makefile variable whose default
>> value is ${cross_prefix}strip. Let's use it.
>>
>> We default to using the non-prefixed strip command in case --enable-debug
>> or --disable-strip was passed to configure during a regular build.
>>
>> Signed-off-by: Greg Kurz <groug@kaod.org>
>> ---
>> v2: - added default value
>> - no longer Cc: qemu-trivial as it turned out to be not that trivial
>>
>> Philippe,
>>
>> Please give your Reviewed-by again if you're okay with this change.
I'm Ok but it got applied faster ;)
>> ---
>> pc-bios/s390-ccw/Makefile | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
>> index 79a46b67356f..fb88c13bc742 100644
>> --- a/pc-bios/s390-ccw/Makefile
>> +++ b/pc-bios/s390-ccw/Makefile
>> @@ -21,8 +21,10 @@ build-all: s390-ccw.img
>> s390-ccw.elf: $(OBJECTS)
>> $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS),"BUILD","$(TARGET_DIR)$@")
>>
>> +STRIP ?= strip
>> +
>> s390-ccw.img: s390-ccw.elf
>> - $(call quiet-command,strip --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
>> + $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
>>
>> $(OBJECTS): Makefile
>>
>>
> applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-31 13:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-31 13:09 [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: use STRIP variable in Makefile Greg Kurz
2017-05-31 13:34 ` Laurent Vivier
2017-05-31 13:41 ` Fam Zheng
2017-05-31 13:50 ` Christian Borntraeger
2017-05-31 13:58 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).