From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dG9RC-0004SQ-Kg for qemu-devel@nongnu.org; Wed, 31 May 2017 15:37:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dG9R8-0004iF-Ka for qemu-devel@nongnu.org; Wed, 31 May 2017 15:37:46 -0400 Date: Wed, 31 May 2017 15:37:37 -0400 From: Jeff Cody Message-ID: <20170531193737.GC4395@localhost.localdomain> References: <20170531192836.7187-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170531192836.7187-1-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH] ide-test: check return of fwrite List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-trivial@nongnu.org, thuth@redhat.com, qemu-devel@nongnu.org On Wed, May 31, 2017 at 03:28:36PM -0400, John Snow wrote: > To quiet patchew, add an assert for fwrite's return value. > > Signed-off-by: John Snow > --- > tests/ide-test.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tests/ide-test.c b/tests/ide-test.c > index 139ebc0..bfd79dd 100644 > --- a/tests/ide-test.c > +++ b/tests/ide-test.c > @@ -796,11 +796,13 @@ static void cdrom_pio_impl(int nblocks) > int i, j; > uint8_t data; > uint16_t limit; > + size_t ret; > > /* Prepopulate the CDROM with an interesting pattern */ > generate_pattern(pattern, patt_len, ATAPI_BLOCK_SIZE); > fh = fopen(tmp_path, "w+"); > - fwrite(pattern, ATAPI_BLOCK_SIZE, patt_blocks, fh); > + ret = fwrite(pattern, ATAPI_BLOCK_SIZE, patt_blocks, fh); > + g_assert_cmpint(ret, ==, patt_blocks); > fclose(fh); > > ide_test_start("-drive if=none,file=%s,media=cdrom,format=raw,id=sr0,index=0 " > @@ -880,6 +882,7 @@ static void test_cdrom_pio_large(void) > static void test_cdrom_dma(void) > { > static const size_t len = ATAPI_BLOCK_SIZE; > + size_t ret; > char *pattern = g_malloc(ATAPI_BLOCK_SIZE * 16); > char *rx = g_malloc0(len); > uintptr_t guest_buf; > @@ -896,7 +899,8 @@ static void test_cdrom_dma(void) > > generate_pattern(pattern, ATAPI_BLOCK_SIZE * 16, ATAPI_BLOCK_SIZE); > fh = fopen(tmp_path, "w+"); > - fwrite(pattern, ATAPI_BLOCK_SIZE, 16, fh); > + ret = fwrite(pattern, ATAPI_BLOCK_SIZE, 16, fh); > + g_assert_cmpint(ret, ==, 16); > fclose(fh); > > send_dma_request(CMD_PACKET, 0, 1, prdt, 1, send_scsi_cdb_read10); > -- > 2.9.4 > > Reviewed-by: Jeff Cody