From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: mdroth@linux.vnet.ibm.com, lvivier@redhat.com,
nikunj@linux.vnet.ibm.com, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org, sursingh@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/4] spapr:DRC cleanups (part I)
Date: Thu, 1 Jun 2017 09:36:46 +0530 [thread overview]
Message-ID: <20170601040646.GB27525@in.ibm.com> (raw)
In-Reply-To: <20170601015218.9299-1-david@gibson.dropbear.id.au>
On Thu, Jun 01, 2017 at 11:52:14AM +1000, David Gibson wrote:
> The code managing DRCs[0] has quite a few things that are more
> complicated than they need to be. In particular the object
> representing a DRC has a bunch of method pointers, despite the fact
> that there are currently no subclasses, and even if there were the
> method implementations would be unlikely to differ.
So you are getting rid of a few methods. How about other methods ?
Specially attach and detach which have incorporated all the logic needed
to handle logical and physical DRs into their implementations ?
Guess these will be follow in subequent parts ?
Regards,
Bharata.
next prev parent reply other threads:[~2017-06-01 4:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 1:52 [Qemu-devel] [PATCH 0/4] spapr:DRC cleanups (part I) David Gibson
2017-06-01 1:52 ` [Qemu-devel] [PATCH 1/4] spapr: Move DRC RTAS calls into spapr_drc.c David Gibson
2017-06-01 13:36 ` Laurent Vivier
2017-06-01 16:05 ` Michael Roth
2017-06-02 3:21 ` David Gibson
2017-06-01 15:56 ` Michael Roth
2017-06-02 3:24 ` David Gibson
2017-06-01 16:08 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-06-01 1:52 ` [Qemu-devel] [PATCH 2/4] spapr: Abolish DRC get_fdt method David Gibson
2017-06-01 14:01 ` Laurent Vivier
2017-06-01 16:09 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-06-01 1:52 ` [Qemu-devel] [PATCH 3/4] spapr: Abolish DRC set_configured method David Gibson
2017-06-01 15:13 ` Laurent Vivier
2017-06-01 15:37 ` Michael Roth
2017-06-02 3:31 ` David Gibson
2017-06-01 16:14 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-06-01 1:52 ` [Qemu-devel] [PATCH 4/4] spapr: Make DRC get_index and get_type methods into plain functions David Gibson
2017-06-01 15:19 ` Laurent Vivier
2017-06-01 4:06 ` Bharata B Rao [this message]
2017-06-01 4:21 ` [Qemu-devel] [PATCH 0/4] spapr:DRC cleanups (part I) David Gibson
2017-06-01 4:25 ` Michael Roth
2017-06-01 5:30 ` David Gibson
2017-06-01 15:41 ` [Qemu-devel] [Qemu-ppc] " Daniel Henrique Barboza
2017-06-02 3:35 ` David Gibson
2017-06-01 13:41 ` Daniel Henrique Barboza
2017-06-02 3:49 ` [Qemu-devel] " David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601040646.GB27525@in.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sursingh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).