From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-block@nongnu.org, jcody@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 4/4] qemu-iotests: Block migration test
Date: Thu, 1 Jun 2017 10:59:50 +0200 [thread overview]
Message-ID: <20170601085950.GA4987@noname.redhat.com> (raw)
In-Reply-To: <b50b7d41-684a-023d-e1f2-d25233140d9f@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
Am 31.05.2017 um 19:03 hat Eric Blake geschrieben:
> On 05/31/2017 04:52 AM, Kevin Wolf wrote:
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> > tests/qemu-iotests/183 | 140 +++++++++++++++++++++++++++++++++++++++++++++
> > tests/qemu-iotests/183.out | 46 +++++++++++++++
> > tests/qemu-iotests/group | 1 +
> > 3 files changed, 187 insertions(+)
> > create mode 100755 tests/qemu-iotests/183
> > create mode 100644 tests/qemu-iotests/183.out
>
> > +qemu_comm_method="qmp"
> > +
> > +_launch_qemu \
> > + -drive file="${TEST_IMG}",cache=${CACHEMODE},driver=$IMGFMT,id=disk
>
> Inconsistent use of ${CACHEMODE} vs. $IMGFMT (I prefer the version with
> less typing, but others prefer always using ${}). In both _launch_qemu
> lines. Up to you if you want to tweak it, but either way,
That's what you get for copying the line and then appending one more
option... I'll remove the extra {} for $CACHEMODE.
Kevin
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2017-06-01 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 9:52 [Qemu-devel] [PATCH v3 0/4] Block migration (migrate -b) fixes Kevin Wolf
2017-05-31 9:52 ` [Qemu-devel] [PATCH v3 1/4] block: Fix anonymous BBs in blk_root_inactivate() Kevin Wolf
2017-05-31 9:52 ` [Qemu-devel] [PATCH v3 2/4] migration: Inactivate images after .save_live_complete_precopy() Kevin Wolf
2017-05-31 9:52 ` [Qemu-devel] [PATCH v3 3/4] migration/block: Clean up BBs in block_save_complete() Kevin Wolf
2017-05-31 9:52 ` [Qemu-devel] [PATCH v3 4/4] qemu-iotests: Block migration test Kevin Wolf
2017-05-31 13:27 ` Jeff Cody
2017-05-31 17:03 ` Eric Blake
2017-06-01 8:59 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601085950.GA4987@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).