From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGOnf-00009E-IV for qemu-devel@nongnu.org; Thu, 01 Jun 2017 08:02:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGOnb-0000rU-Mb for qemu-devel@nongnu.org; Thu, 01 Jun 2017 08:01:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49604) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dGOnb-0000rJ-Em for qemu-devel@nongnu.org; Thu, 01 Jun 2017 08:01:55 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 660AA7E9ED for ; Thu, 1 Jun 2017 12:01:35 +0000 (UTC) Date: Thu, 1 Jun 2017 13:00:10 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170601120010.GI2083@work-vm> References: <20170531103509.22021-1-quintela@redhat.com> <20170531103509.22021-2-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20170531103509.22021-2-quintela@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 01/10] migration: Remove unneeded includes of migration/vmstate.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com * Juan Quintela (quintela@redhat.com) wrote: > Signed-off-by: Juan Quintela > Reviewed-by: Philippe Mathieu-Daud=E9 Reviewed-by: Dr. David Alan Gilbert > --- > hw/core/qdev.c | 1 - > include/hw/acpi/memory_hotplug.h | 1 - > include/hw/acpi/pcihp.h | 1 - > include/hw/pci/shpc.h | 1 - > target/alpha/cpu.c | 1 - > target/hppa/cpu.c | 1 - > target/s390x/cpu.c | 1 - > target/tilegx/cpu.c | 1 - > 8 files changed, 8 deletions(-) >=20 > diff --git a/hw/core/qdev.c b/hw/core/qdev.c > index 71ff95f..0ce45a2 100644 > --- a/hw/core/qdev.c > +++ b/hw/core/qdev.c > @@ -37,7 +37,6 @@ > #include "hw/boards.h" > #include "hw/sysbus.h" > #include "qapi-event.h" > -#include "migration/vmstate.h" > =20 > bool qdev_hotplug =3D false; > static bool qdev_hot_added =3D false; > diff --git a/include/hw/acpi/memory_hotplug.h b/include/hw/acpi/memory_= hotplug.h > index db8ebc9..77c6576 100644 > --- a/include/hw/acpi/memory_hotplug.h > +++ b/include/hw/acpi/memory_hotplug.h > @@ -3,7 +3,6 @@ > =20 > #include "hw/qdev-core.h" > #include "hw/acpi/acpi.h" > -#include "migration/vmstate.h" > #include "hw/acpi/aml-build.h" > =20 > /** > diff --git a/include/hw/acpi/pcihp.h b/include/hw/acpi/pcihp.h > index 04528b7..8a65f99 100644 > --- a/include/hw/acpi/pcihp.h > +++ b/include/hw/acpi/pcihp.h > @@ -28,7 +28,6 @@ > #define HW_ACPI_PCIHP_H > =20 > #include "hw/acpi/acpi.h" > -#include "migration/vmstate.h" > #include "hw/hotplug.h" > =20 > #define ACPI_PCIHP_IO_BASE_PROP "acpi-pcihp-io-base" > diff --git a/include/hw/pci/shpc.h b/include/hw/pci/shpc.h > index b208554..71e836b 100644 > --- a/include/hw/pci/shpc.h > +++ b/include/hw/pci/shpc.h > @@ -3,7 +3,6 @@ > =20 > #include "qemu-common.h" > #include "exec/memory.h" > -#include "migration/vmstate.h" > #include "hw/hotplug.h" > #include "hw/pci/pci.h" > =20 > diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c > index b4f9798..8186c9d 100644 > --- a/target/alpha/cpu.c > +++ b/target/alpha/cpu.c > @@ -23,7 +23,6 @@ > #include "qapi/error.h" > #include "cpu.h" > #include "qemu-common.h" > -#include "migration/vmstate.h" > #include "exec/exec-all.h" > =20 > =20 > diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c > index 1d791d0..30299e9 100644 > --- a/target/hppa/cpu.c > +++ b/target/hppa/cpu.c > @@ -22,7 +22,6 @@ > #include "qapi/error.h" > #include "cpu.h" > #include "qemu-common.h" > -#include "migration/vmstate.h" > #include "exec/exec-all.h" > =20 > =20 > diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c > index a69005d..accef03 100644 > --- a/target/s390x/cpu.c > +++ b/target/s390x/cpu.c > @@ -32,7 +32,6 @@ > #include "qemu/error-report.h" > #include "trace.h" > #include "qapi/visitor.h" > -#include "migration/vmstate.h" > #include "exec/exec-all.h" > #ifndef CONFIG_USER_ONLY > #include "hw/hw.h" > diff --git a/target/tilegx/cpu.c b/target/tilegx/cpu.c > index d90e38e..4532639 100644 > --- a/target/tilegx/cpu.c > +++ b/target/tilegx/cpu.c > @@ -23,7 +23,6 @@ > #include "cpu.h" > #include "qemu-common.h" > #include "hw/qdev-properties.h" > -#include "migration/vmstate.h" > #include "linux-user/syscall_defs.h" > #include "exec/exec-all.h" > =20 > --=20 > 2.9.4 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK