From: Zhong Yang <yang.zhong@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Eric Blake <eblake@redhat.com>,
Laurent Desnogues <laurent.desnogues@gmail.com>,
anthony.xu@intel.com,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 0/6] tcg: move the tcg files into tcg/ subdirectory.
Date: Thu, 1 Jun 2017 20:04:54 +0800 [thread overview]
Message-ID: <20170601120454.GB18829@yangzhon-Virtual> (raw)
In-Reply-To: <fc8f01b6-5b87-bd9e-0648-b489e00a6dfe@redhat.com>
On Thu, Jun 01, 2017 at 10:14:34AM +0200, Paolo Bonzini wrote:
>
>
> On 01/06/2017 07:27, Zhong Yang wrote:
> > In the first phase, there are three patchsets to
> > deal with split code and separate the files.
> > 1) split the tcg exec code.
> > a)split the tcg accelerators from accel.c file and re-name
> > tcg accelerator to tcg-all.c, like kvm-all.c did.
> > b)create one accel directory, which will include kvm,
> > tcg and general exec files.
> > c)move tcg exec files into ./accel/tcg directory.
> > 2) move tcg related backend files into tcg/ directory
> > those files include translate-all.(ch), translate-common.c,
> > tci.c and tcg-runtime.c.
> > 3) move kvm exec and exec.c file.
> > a)move kvm related exec files into ./accel/kvm directory.
> > b)move exec.c in ./accel directory.
> >
> > after 1) and 3) done, the file tree like below:
> > accel/
> > ├── accel.c
> > ├── exec.c
> > ├── kvm
> > │ ├── kvm-all.c
> > │ ├── kvm-stub.c
> > │ ├── Makefile.objs
> > │ └── trace-events
> > ├── Makefile.objs
> > └── tcg
> > ├── cpu-exec.c
> > ├── cpu-exec-common.c
> > ├── cputlb.c
> > ├── Makefile.objs
> > ├── tcg-all.c
> > └── trace-events
> >
> > please help me check whether this kind of arrange is suitable?
>
> Oh, I see now. I think translate-all.[ch] and translate-common.c belong
> in accel/tcg more than tcg/.
okay, i will make those changes into one patchset and send v3 to all, thanks!
Yang.
>
> Thanks,
>
> Paolo
prev parent reply other threads:[~2017-06-01 12:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 6:28 [Qemu-devel] [PATCH v2 0/6] tcg: move the tcg files into tcg/ subdirectory Yang Zhong
2017-05-31 6:28 ` [Qemu-devel] [PATCH v2 1/6] tcg: move tcg-runtime.c to " Yang Zhong
2017-05-31 6:29 ` [Qemu-devel] [PATCH v2 2/6] tcg: move translate-all.c " Yang Zhong
2017-05-31 6:29 ` [Qemu-devel] [PATCH v2 3/6] tcg: move tcg header file Yang Zhong
2017-05-31 6:29 ` [Qemu-devel] [PATCH v2 4/6] tcg: move translate-common.c to tcg/ subdirectory Yang Zhong
2017-05-31 6:29 ` [Qemu-devel] [PATCH v2 5/6] tcg: move tci.c " Yang Zhong
2017-05-31 6:29 ` [Qemu-devel] [PATCH v2 6/6] tcg: change tcg related file's compile definition Yang Zhong
2017-05-31 12:54 ` [Qemu-devel] [PATCH v2 0/6] tcg: move the tcg files into tcg/ subdirectory Paolo Bonzini
2017-05-31 16:24 ` Laurent Desnogues
2017-05-31 19:05 ` Paolo Bonzini
2017-06-01 5:27 ` Zhong Yang
2017-06-01 8:14 ` Paolo Bonzini
2017-06-01 12:04 ` Zhong Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601120454.GB18829@yangzhon-Virtual \
--to=yang.zhong@intel.com \
--cc=anthony.xu@intel.com \
--cc=eblake@redhat.com \
--cc=laurent.desnogues@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).