From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGPLu-0001VS-7C for qemu-devel@nongnu.org; Thu, 01 Jun 2017 08:37:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGPLp-00043D-At for qemu-devel@nongnu.org; Thu, 01 Jun 2017 08:37:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58650) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dGPLp-000430-2n for qemu-devel@nongnu.org; Thu, 01 Jun 2017 08:37:17 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 010621A672D for ; Thu, 1 Jun 2017 12:37:16 +0000 (UTC) Date: Thu, 1 Jun 2017 13:37:10 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170601123709.GN2083@work-vm> References: <20170531103509.22021-1-quintela@redhat.com> <20170531103509.22021-6-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170531103509.22021-6-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 05/10] migration: Export socket.c functions in its own file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com * Juan Quintela (quintela@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 8 -------- > migration/migration.c | 1 + > migration/socket.c | 1 + > migration/socket.h | 28 ++++++++++++++++++++++++++++ > 4 files changed, 30 insertions(+), 8 deletions(-) > create mode 100644 migration/socket.h > > diff --git a/include/migration/migration.h b/include/migration/migration.h > index d249c13..9d311ed 100644 > --- a/include/migration/migration.h > +++ b/include/migration/migration.h > @@ -163,14 +163,6 @@ void migration_tls_channel_connect(MigrationState *s, > > uint64_t migrate_max_downtime(void); > > -void tcp_start_incoming_migration(const char *host_port, Error **errp); > - > -void tcp_start_outgoing_migration(MigrationState *s, const char *host_port, Error **errp); > - > -void unix_start_incoming_migration(const char *path, Error **errp); > - > -void unix_start_outgoing_migration(MigrationState *s, const char *path, Error **errp); > - > void rdma_start_outgoing_migration(void *opaque, const char *host_port, Error **errp); > > void rdma_start_incoming_migration(const char *host_port, Error **errp); > diff --git a/migration/migration.c b/migration/migration.c > index f3a1236..f5140d2 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -20,6 +20,7 @@ > #include "migration/blocker.h" > #include "exec.h" > #include "fd.h" > +#include "socket.h" > #include "migration/migration.h" > #include "savevm.h" > #include "qemu-file-channel.h" > diff --git a/migration/socket.c b/migration/socket.c > index 3f8ffc9..85bfdcc 100644 > --- a/migration/socket.c > +++ b/migration/socket.c > @@ -20,6 +20,7 @@ > #include "qemu/error-report.h" > #include "qapi/error.h" > #include "channel.h" > +#include "socket.h" > #include "migration/migration.h" > #include "qemu-file.h" > #include "io/channel-socket.h" > diff --git a/migration/socket.h b/migration/socket.h > new file mode 100644 > index 0000000..6b91e9d > --- /dev/null > +++ b/migration/socket.h > @@ -0,0 +1,28 @@ > +/* > + * QEMU live migration via socket > + * > + * Copyright Red Hat, Inc. 2009-2016 > + * > + * Authors: > + * Chris Lalancette > + * Daniel P. Berrange > + * > + * This work is licensed under the terms of the GNU GPL, version 2. See > + * the COPYING file in the top-level directory. > + * > + * Contributions after 2012-01-13 are licensed under the terms of the > + * GNU GPL, version 2 or (at your option) any later version. > + */ > + > +#ifndef QEMU_MIGRATION_SOCKET_H > +#define QEMU_MIGRATION_SOCKET_H > +void tcp_start_incoming_migration(const char *host_port, Error **errp); > + > +void tcp_start_outgoing_migration(MigrationState *s, const char *host_port, > + Error **errp); > + > +void unix_start_incoming_migration(const char *path, Error **errp); > + > +void unix_start_outgoing_migration(MigrationState *s, const char *path, > + Error **errp); > +#endif > -- > 2.9.4 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK