From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGO3K-0001bz-5I for qemu-devel@nongnu.org; Thu, 01 Jun 2017 07:14:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGO3G-0005pV-T2 for qemu-devel@nongnu.org; Thu, 01 Jun 2017 07:14:06 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:50298 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dGO3G-0005pJ-M7 for qemu-devel@nongnu.org; Thu, 01 Jun 2017 07:14:02 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v51BDkkt077232 for ; Thu, 1 Jun 2017 07:14:01 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2atfv7pcvk-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 01 Jun 2017 07:14:01 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 1 Jun 2017 12:14:00 +0100 Date: Thu, 1 Jun 2017 13:13:53 +0200 From: Cornelia Huck In-Reply-To: <20170529135520.101429-3-pasic@linux.vnet.ibm.com> References: <20170529135520.101429-1-pasic@linux.vnet.ibm.com> <20170529135520.101429-3-pasic@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20170601131353.36e40dac.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 2/7] s390x: add helper get_machine_class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic Cc: "Dr. David Alan Gilbert" , Dong Jia Shi , Juan Quintela , qemu-devel@nongnu.org On Mon, 29 May 2017 15:55:15 +0200 Halil Pasic wrote: > We will need the machine class at machine initialization time, so the > usual way via qdev won't do. Let's cache the machine class and also use > the default values of the base machine for capability discovery. > > Signed-off-by: Halil Pasic > --- > hw/s390x/s390-virtio-ccw.c | 46 +++++++++++++++++++++++----------------------- > 1 file changed, 23 insertions(+), 23 deletions(-) I'm still not sure if that is the best way to go; but if it isn't, I'm unable to find that better path. So, Acked-by: Cornelia Huck