From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Halil Pasic <pasic@linux.vnet.ibm.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,
Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 7/7] s390x/css: use SubchDev.orb
Date: Thu, 1 Jun 2017 13:50:06 +0200 [thread overview]
Message-ID: <20170601135006.5a33a20c.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20170529135520.101429-8-pasic@linux.vnet.ibm.com>
On Mon, 29 May 2017 15:55:20 +0200
Halil Pasic <pasic@linux.vnet.ibm.com> wrote:
> Instead of passing around a pointer to ORB let us simplify some
> functions signatures by using the previously introduced ORB saved at the
Either "function signatures" or "functions' signatures" :)
> subchannel (SubchDev).
>
> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> Reviewed-by: Guenther Hutzl <hutzl@linux.vnet.ibm.com>
> ---
> hw/s390x/css.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
This is a nice rework.
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
next prev parent reply other threads:[~2017-06-01 11:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 13:55 [Qemu-devel] [PATCH v2 0/7] migration: s390x css migration Halil Pasic
2017-05-29 13:55 ` [Qemu-devel] [PATCH v2 1/7] s390x: vmstatify config migration for virtio-ccw Halil Pasic
2017-05-29 13:55 ` [Qemu-devel] [PATCH v2 2/7] s390x: add helper get_machine_class Halil Pasic
2017-06-01 11:13 ` Cornelia Huck
2017-05-29 13:55 ` [Qemu-devel] [PATCH v2 3/7] s390x: add css_migration_enabled to machine class Halil Pasic
2017-06-01 11:16 ` Cornelia Huck
2017-05-29 13:55 ` [Qemu-devel] [PATCH v2 4/7] s390x/css: add missing css state conditionally Halil Pasic
2017-05-31 18:52 ` Juan Quintela
2017-06-01 9:35 ` Halil Pasic
2017-06-01 11:32 ` Cornelia Huck
2017-06-01 11:46 ` Halil Pasic
2017-06-07 18:03 ` Juan Quintela
2017-06-08 8:52 ` Halil Pasic
2017-06-01 11:42 ` Cornelia Huck
2017-05-29 13:55 ` [Qemu-devel] [PATCH v2 5/7] s390x/css: add ORB to SubchDev Halil Pasic
2017-06-01 11:45 ` Cornelia Huck
2017-05-29 13:55 ` [Qemu-devel] [PATCH v2 6/7] s390x/css: activate ChannelSubSys migration Halil Pasic
2017-06-01 8:40 ` Thomas Huth
2017-06-01 10:12 ` Halil Pasic
2017-06-01 11:47 ` Cornelia Huck
2017-05-29 13:55 ` [Qemu-devel] [PATCH v2 7/7] s390x/css: use SubchDev.orb Halil Pasic
2017-06-01 11:50 ` Cornelia Huck [this message]
2017-05-31 16:46 ` [Qemu-devel] [PATCH v2 0/7] migration: s390x css migration Dr. David Alan Gilbert
2017-06-01 11:51 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601135006.5a33a20c.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=dgilbert@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).