From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGOcM-0002YZ-JV for qemu-devel@nongnu.org; Thu, 01 Jun 2017 07:50:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGOcI-0004tQ-GE for qemu-devel@nongnu.org; Thu, 01 Jun 2017 07:50:18 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57160) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dGOcI-0004tJ-64 for qemu-devel@nongnu.org; Thu, 01 Jun 2017 07:50:14 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v51BnIRL005441 for ; Thu, 1 Jun 2017 07:50:12 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 2at85r47ut-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 01 Jun 2017 07:50:12 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 1 Jun 2017 12:50:10 +0100 Date: Thu, 1 Jun 2017 13:50:06 +0200 From: Cornelia Huck In-Reply-To: <20170529135520.101429-8-pasic@linux.vnet.ibm.com> References: <20170529135520.101429-1-pasic@linux.vnet.ibm.com> <20170529135520.101429-8-pasic@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20170601135006.5a33a20c.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 7/7] s390x/css: use SubchDev.orb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic Cc: "Dr. David Alan Gilbert" , Dong Jia Shi , Juan Quintela , qemu-devel@nongnu.org On Mon, 29 May 2017 15:55:20 +0200 Halil Pasic wrote: > Instead of passing around a pointer to ORB let us simplify some > functions signatures by using the previously introduced ORB saved at the Either "function signatures" or "functions' signatures" :) > subchannel (SubchDev). > > Signed-off-by: Halil Pasic > Reviewed-by: Guenther Hutzl > --- > hw/s390x/css.c | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) This is a nice rework. Reviewed-by: Cornelia Huck