From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, armbru@redhat.com,
eblake@redhat.com, jsnow@redhat.com, famz@redhat.com,
den@openvz.org, stefanha@redhat.com, vsementsov@virtuozzo.com,
pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v20 16/30] block: bdrv_close: release bitmaps after drv->bdrv_close
Date: Fri, 2 Jun 2017 14:21:44 +0300 [thread overview]
Message-ID: <20170602112158.232757-17-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20170602112158.232757-1-vsementsov@virtuozzo.com>
Release bitmaps after 'if (bs->drv) { ... }' block. This will allow
format driver to save persistent bitmaps, which will appear in following
commits.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
block.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
index 161db9e32a..b35387241a 100644
--- a/block.c
+++ b/block.c
@@ -3015,9 +3015,6 @@ static void bdrv_close(BlockDriverState *bs)
bdrv_flush(bs);
bdrv_drain(bs); /* in case flush left pending I/O */
- bdrv_release_named_dirty_bitmaps(bs);
- assert(QLIST_EMPTY(&bs->dirty_bitmaps));
-
if (bs->drv) {
BdrvChild *child, *next;
@@ -3056,6 +3053,9 @@ static void bdrv_close(BlockDriverState *bs)
bs->full_open_options = NULL;
}
+ bdrv_release_named_dirty_bitmaps(bs);
+ assert(QLIST_EMPTY(&bs->dirty_bitmaps));
+
QLIST_FOREACH_SAFE(ban, &bs->aio_notifiers, list, ban_next) {
g_free(ban);
}
--
2.11.1
next prev parent reply other threads:[~2017-06-02 11:22 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 11:21 [Qemu-devel] [PATCH v20 00/30] qcow2: persistent dirty bitmaps Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 01/30] specs/qcow2: fix bitmap granularity qemu-specific note Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 02/30] specs/qcow2: do not use wording 'bitmap header' Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 03/30] hbitmap: improve dirty iter Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 04/30] tests: add hbitmap iter test Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 05/30] block: fix bdrv_dirty_bitmap_granularity signature Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 06/30] block/dirty-bitmap: add deserialize_ones func Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 07/30] qcow2-refcount: rename inc_refcounts() and make it public Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 08/30] qcow2: add bitmaps extension Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 09/30] block/dirty-bitmap: fix comment for BlockDirtyBitmap.disabled field Vladimir Sementsov-Ogievskiy
2017-06-02 21:02 ` John Snow
2017-06-09 12:29 ` Max Reitz
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 10/30] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap Vladimir Sementsov-Ogievskiy
2017-06-02 21:02 ` John Snow
2017-06-03 17:19 ` Sementsov-Ogievskiy Vladimir
2017-06-09 12:56 ` Max Reitz
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 11/30] qcow2: autoloading dirty bitmaps Vladimir Sementsov-Ogievskiy
2017-06-02 21:48 ` John Snow
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 12/30] block: refactor bdrv_reopen_commit Vladimir Sementsov-Ogievskiy
2017-06-02 21:57 ` John Snow
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 13/30] block: new bdrv_reopen_bitmaps_rw interface Vladimir Sementsov-Ogievskiy
2017-06-02 22:17 ` John Snow
2017-06-03 16:53 ` Sementsov-Ogievskiy Vladimir
2017-06-09 13:27 ` Max Reitz
2017-06-13 10:25 ` Vladimir Sementsov-Ogievskiy
2017-06-13 15:28 ` Max Reitz
2017-06-14 9:03 ` Vladimir Sementsov-Ogievskiy
2017-06-14 12:04 ` Max Reitz
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 14/30] qcow2: support .bdrv_reopen_bitmaps_rw Vladimir Sementsov-Ogievskiy
2017-06-02 23:09 ` John Snow
2017-06-09 13:38 ` Max Reitz
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 15/30] block/dirty-bitmap: add autoload field to BdrvDirtyBitmap Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` Vladimir Sementsov-Ogievskiy [this message]
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 17/30] block: introduce persistent dirty bitmaps Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 18/30] block/dirty-bitmap: add bdrv_dirty_bitmap_next() Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 19/30] qcow2: add persistent dirty bitmaps support Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 20/30] qcow2: store bitmaps on reopening image as read-only Vladimir Sementsov-Ogievskiy
2017-06-09 13:48 ` Max Reitz
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 21/30] block: add bdrv_can_store_new_dirty_bitmap Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 22/30] qcow2: add .bdrv_can_store_new_dirty_bitmap Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 23/30] qmp: add persistent flag to block-dirty-bitmap-add Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 24/30] qmp: add autoload parameter " Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 25/30] qmp: add x-debug-block-dirty-bitmap-sha256 Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 26/30] iotests: test qcow2 persistent dirty bitmap Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 27/30] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 28/30] qcow2: add .bdrv_remove_persistent_dirty_bitmap Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 29/30] qmp: block-dirty-bitmap-remove: remove persistent Vladimir Sementsov-Ogievskiy
2017-06-02 11:21 ` [Qemu-devel] [PATCH v20 30/30] block: release persistent bitmaps on inactivate Vladimir Sementsov-Ogievskiy
2017-06-09 14:01 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170602112158.232757-17-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).