qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Emilio G. Cota" <cota@braap.org>
To: "James J. Nutaro" <nutarojj@ornl.gov>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH V8] qqq: module for synchronizing with a simulation
Date: Fri, 2 Jun 2017 10:42:33 -0400	[thread overview]
Message-ID: <20170602144233.GA4868@flamenco> (raw)
In-Reply-To: <1487097476-14259-1-git-send-email-nutarojj@ornl.gov>

On Tue, Feb 14, 2017 at 13:37:56 -0500, James J. Nutaro wrote:
> This patch adds an interface for pacing the execution of QEMU to match an external
> simulation clock. Its aim is to permit QEMU to be used as a module within a
> larger simulation system.
(snip)
> +++ b/docs/simulation-sync.txt
> @@ -0,0 +1,59 @@
> += Synchronizing the virtual clock with an external source =
> +
> +QEMU has a protocol for synchronizing its virtual clock
> +with the clock of a simulator in which QEMU is embedded
> +as a component. This options is enabled with the -qqq
> +argument, and it should generally be accompanied by the
> +following additional command line arguments:
> +
> +-icount 1,sleep=off -rtc clock=vm
> +  or
> +-enable-kvm -rtc clock=vm

Isn't this a KVM-only feature though? I don't see calls to qqq_sync()
anywhere but from kvm-all.c, but maybe I'm missing something.

Also, a few more comments:

- Why "qqq" as the name for this feature? I fail to see any
  connection between the name and the feature.

- If Windows users ever wanted this feature, would we have to
  change the user-facing API (i.e. the -qqq parameter)?

- As is, isn't the code Unix-only rather than Linux-only?

Thanks,

		Emilio

  reply	other threads:[~2017-06-02 14:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 18:37 [Qemu-devel] [PATCH V8] qqq: module for synchronizing with a simulation James J. Nutaro
2017-06-02 14:42 ` Emilio G. Cota [this message]
2017-06-13 13:13   ` Nutaro, James J.
2017-09-19 21:43 ` nutarojj
2017-10-23 16:23   ` Emilio G. Cota

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170602144233.GA4868@flamenco \
    --to=cota@braap.org \
    --cc=nutarojj@ornl.gov \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).