From: Krzysztof Kozlowski <krzk@kernel.org>
To: Igor Mitsyanko <i.mitsyanko@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Eric Blake" <eblake@redhat.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>
Subject: [Qemu-devel] [PATCH v4 6/9] hw/arm/exynos: Declare local variables in some order
Date: Fri, 2 Jun 2017 18:36:15 +0200 [thread overview]
Message-ID: <20170602163618.6369-6-krzk@kernel.org> (raw)
In-Reply-To: <20170602163618.6369-1-krzk@kernel.org>
Bring some more readability by declaring local function variables: first
initialized ones and then the rest (with reversed-christmas-tree order).
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/arm/exynos4210.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c
index 0da877f8db0a..27a7bf28a5a9 100644
--- a/hw/arm/exynos4210.c
+++ b/hw/arm/exynos4210.c
@@ -162,12 +162,12 @@ static uint64_t exynos4210_calc_affinity(int cpu)
Exynos4210State *exynos4210_init(MemoryRegion *system_mem)
{
- int i, n;
Exynos4210State *s = g_new(Exynos4210State, 1);
qemu_irq gate_irq[EXYNOS4210_NCPUS][EXYNOS4210_IRQ_GATE_NINPUTS];
- DeviceState *dev;
SysBusDevice *busdev;
ObjectClass *cpu_oc;
+ DeviceState *dev;
+ int i, n;
cpu_oc = cpu_class_by_name(TYPE_ARM_CPU, "cortex-a9");
assert(cpu_oc);
--
2.9.3
next prev parent reply other threads:[~2017-06-02 16:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 16:28 [Qemu-devel] [PATCH v4 0/9] hw: arm: exynos: Improvements and cleanups Krzysztof Kozlowski
2017-06-02 16:36 ` [Qemu-devel] [PATCH v4 1/9] hw/intc/exynos4210_gic: Use more meaningful name for local variable Krzysztof Kozlowski
2017-06-02 16:36 ` [Qemu-devel] [PATCH v4 2/9] hw/timer/exynos4210_mct: Fix checkpatch style errors Krzysztof Kozlowski
2017-06-02 18:36 ` Philippe Mathieu-Daudé
2017-06-02 16:36 ` [Qemu-devel] [PATCH v4 3/9] hw/timer/exynos4210_mct: Cleanup indentation and empty new lines Krzysztof Kozlowski
2017-06-02 18:36 ` Philippe Mathieu-Daudé
2017-06-02 16:36 ` [Qemu-devel] [PATCH v4 4/9] hw/timer/exynos4210_mct: Remove unused defines Krzysztof Kozlowski
2017-06-02 16:36 ` [Qemu-devel] [PATCH v4 5/9] hw/arm/exynos: Move DRAM initialization next boards Krzysztof Kozlowski
2017-06-02 16:36 ` Krzysztof Kozlowski [this message]
2017-06-02 16:36 ` [Qemu-devel] [PATCH v4 7/9] hw/arm/exynos: Use type define instead of hard-coded a9mpcore_priv string Krzysztof Kozlowski
2017-06-02 16:36 ` [Qemu-devel] [PATCH v4 8/9] hw/intc/exynos4210_gic: Constify array of combiner interrupts Krzysztof Kozlowski
2017-06-02 16:36 ` [Qemu-devel] [PATCH v4 9/9] hw/misc/exynos4210_pmu: Add support for system poweroff Krzysztof Kozlowski
2017-06-02 18:38 ` Philippe Mathieu-Daudé
2017-06-02 18:35 ` [Qemu-devel] [PATCH v4 1/9] hw/intc/exynos4210_gic: Use more meaningful name for local variable Philippe Mathieu-Daudé
2017-06-06 17:14 ` [Qemu-devel] [PATCH v4 0/9] hw: arm: exynos: Improvements and cleanups Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170602163618.6369-6-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=i.mitsyanko@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).