From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIGKT-0001k1-Ic for qemu-devel@nongnu.org; Tue, 06 Jun 2017 11:23:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIGKO-0006do-HZ for qemu-devel@nongnu.org; Tue, 06 Jun 2017 11:23:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34984) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dIGKO-0006dD-BP for qemu-devel@nongnu.org; Tue, 06 Jun 2017 11:23:28 -0400 Date: Tue, 6 Jun 2017 18:23:25 +0300 From: "Michael S. Tsirkin" Message-ID: <20170606182005-mutt-send-email-mst@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 0/6] Convert to realize and cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mao Zhongyi Cc: qemu-devel@nongnu.org Notes: - Please write a cover letter explaining what this patchset is about - Please add notes about how did you test it - Pls copy everyone on the cover letter too. - Please run a spell checker on comments and commit log Thanks! On Fri, Jun 02, 2017 at 03:54:36PM +0800, Mao Zhongyi wrote: > v2: > * patch1: subject and commit message was rewrited by markus. > * patch2: comment was added to pci_add_capability2(). > * patch3: a new patch that fix the wrong return value judgment condition. > * patch4: a new patch that fix code style problems. > * patch5: add an errp argument for pci_add_capability to pass > error for its callers. > * patch6: convert part of pci-bridge device to realize. > > v1: > * patch1: fix unreasonable return value check > Mao Zhongyi (6): > pci: Clean up error checking in pci_add_capability() > pci: Add comment for pci_add_capability2() > pci: Fix the wrong return value judgment condition > net/eepro100: Fixed code style > pci: Make errp the last parameter of pci_add_capability() > pci: Convert to realize > > hw/i386/amd_iommu.c | 24 ++++++++---- > hw/net/e1000e.c | 9 ++++- > hw/net/eepro100.c | 77 +++++++++++++++++++++----------------- > hw/pci-bridge/i82801b11.c | 12 +++--- > hw/pci-bridge/pcie_root_port.c | 15 +++----- > hw/pci-bridge/xio3130_downstream.c | 20 +++++----- > hw/pci-bridge/xio3130_upstream.c | 20 +++++----- > hw/pci/pci.c | 18 ++++----- > hw/pci/pci_bridge.c | 8 +++- > hw/pci/pcie.c | 15 ++++++-- > hw/pci/shpc.c | 5 ++- > hw/pci/slotid_cap.c | 7 +++- > hw/vfio/pci.c | 5 ++- > hw/virtio/virtio-pci.c | 19 +++++++--- > include/hw/pci/pci.h | 3 +- > include/hw/pci/pci_bridge.h | 3 +- > include/hw/pci/pcie.h | 3 +- > 17 files changed, 154 insertions(+), 109 deletions(-) > > -- > 2.9.3 > > >