From: David Gibson <david@gibson.dropbear.id.au>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
qemu-ppc@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] ppc: fix memory leaks
Date: Wed, 7 Jun 2017 09:45:06 +1000 [thread overview]
Message-ID: <20170606234506.GF13397@umbus.fritz.box> (raw)
In-Reply-To: <149676256254.31274.13156728863519964419.stgit@bahia.lab.toulouse-stg.fr.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 797 bytes --]
On Tue, Jun 06, 2017 at 05:22:42PM +0200, Greg Kurz wrote:
> Coverity just reported a memory leak introduced by this commit (QEMU 2.9):
>
> commit df58713396f8b2deb923e39c00b10744c5c63909
> Author: Thomas Huth <thuth@redhat.com>
> Date: Wed Feb 15 10:21:44 2017 +0100
>
> hw/ppc/spapr: Check for valid page size when hot plugging memory
>
> It boils down to the fact that object_property_get_str() returns a string
> allocated with g_strdup(), which must be deallocated with g_free() at some
> point.
Applied to ppc-for-2.10. Do we need to queue this for 2.9 stable as
well?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-06-07 3:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 15:22 [Qemu-devel] [PATCH 0/3] ppc: fix memory leaks Greg Kurz
2017-06-06 15:22 ` [Qemu-devel] [PATCH 1/3] target/ppc: pass const pointer to kvmppc_is_mem_backend_page_size_ok() Greg Kurz
2017-06-06 15:33 ` Philippe Mathieu-Daudé
2017-06-06 15:34 ` Thomas Huth
2017-06-06 15:46 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-06-06 16:12 ` [Qemu-devel] [PATCH v2] target/ppc: pass const string " Greg Kurz
2017-06-06 16:34 ` Thomas Huth
2017-06-06 15:22 ` [Qemu-devel] [PATCH 2/3] target/ppc: fix memory leak in kvmppc_is_mem_backend_page_size_ok() Greg Kurz
2017-06-06 15:28 ` Peter Maydell
2017-06-06 15:41 ` Greg Kurz
2017-06-06 15:43 ` Peter Maydell
2017-06-06 15:41 ` Thomas Huth
2017-06-06 15:22 ` [Qemu-devel] [PATCH 3/3] spapr: fix memory leak in spapr_memory_pre_plug() Greg Kurz
2017-06-06 15:43 ` Thomas Huth
2017-06-06 15:55 ` Greg Kurz
2017-06-06 23:45 ` David Gibson [this message]
2017-06-07 5:45 ` [Qemu-devel] [PATCH 0/3] ppc: fix memory leaks Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606234506.GF13397@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).