* [Qemu-devel] [PATCH] hw/pcie: fix the generic pcie root port to support migration
@ 2017-06-07 10:24 Marcel Apfelbaum
2017-06-07 10:27 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Marcel Apfelbaum @ 2017-06-07 10:24 UTC (permalink / raw)
To: qemu-devel; +Cc: marcel, mst, dgilbert
Add msix state to pcie-root-ports's vmstate
in order to support migration.
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
hw/pci-bridge/gen_pcie_root_port.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/pci-bridge/gen_pcie_root_port.c b/hw/pci-bridge/gen_pcie_root_port.c
index 8ebffa8..d24aa8a 100644
--- a/hw/pci-bridge/gen_pcie_root_port.c
+++ b/hw/pci-bridge/gen_pcie_root_port.c
@@ -54,6 +54,7 @@ static const VMStateDescription vmstate_rp_dev = {
VMSTATE_PCI_DEVICE(parent_obj.parent_obj.parent_obj, PCIESlot),
VMSTATE_STRUCT(parent_obj.parent_obj.parent_obj.exp.aer_log,
PCIESlot, 0, vmstate_pcie_aer_log, PCIEAERLog),
+ VMSTATE_MSIX(parent_obj.parent_obj, PCIEPort),
VMSTATE_END_OF_LIST()
}
};
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hw/pcie: fix the generic pcie root port to support migration
2017-06-07 10:24 [Qemu-devel] [PATCH] hw/pcie: fix the generic pcie root port to support migration Marcel Apfelbaum
@ 2017-06-07 10:27 ` Dr. David Alan Gilbert
2017-06-07 11:09 ` Marcel Apfelbaum
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2017-06-07 10:27 UTC (permalink / raw)
To: Marcel Apfelbaum; +Cc: qemu-devel, mst
* Marcel Apfelbaum (marcel@redhat.com) wrote:
> Add msix state to pcie-root-ports's vmstate
> in order to support migration.
>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
> hw/pci-bridge/gen_pcie_root_port.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/pci-bridge/gen_pcie_root_port.c b/hw/pci-bridge/gen_pcie_root_port.c
> index 8ebffa8..d24aa8a 100644
> --- a/hw/pci-bridge/gen_pcie_root_port.c
> +++ b/hw/pci-bridge/gen_pcie_root_port.c
> @@ -54,6 +54,7 @@ static const VMStateDescription vmstate_rp_dev = {
> VMSTATE_PCI_DEVICE(parent_obj.parent_obj.parent_obj, PCIESlot),
> VMSTATE_STRUCT(parent_obj.parent_obj.parent_obj.exp.aer_log,
> PCIESlot, 0, vmstate_pcie_aer_log, PCIEAERLog),
> + VMSTATE_MSIX(parent_obj.parent_obj, PCIEPort),
That will cause a failure of migration from/to 2.9.
Doesn't that need to be tied to the machine-type in a subsection?
Dave
> VMSTATE_END_OF_LIST()
> }
> };
> --
> 2.9.4
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hw/pcie: fix the generic pcie root port to support migration
2017-06-07 10:27 ` Dr. David Alan Gilbert
@ 2017-06-07 11:09 ` Marcel Apfelbaum
0 siblings, 0 replies; 3+ messages in thread
From: Marcel Apfelbaum @ 2017-06-07 11:09 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: qemu-devel, mst
On 07/06/2017 13:27, Dr. David Alan Gilbert wrote:
> * Marcel Apfelbaum (marcel@redhat.com) wrote:
>> Add msix state to pcie-root-ports's vmstate
>> in order to support migration.
>>
>> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
>> ---
>> hw/pci-bridge/gen_pcie_root_port.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/pci-bridge/gen_pcie_root_port.c b/hw/pci-bridge/gen_pcie_root_port.c
>> index 8ebffa8..d24aa8a 100644
>> --- a/hw/pci-bridge/gen_pcie_root_port.c
>> +++ b/hw/pci-bridge/gen_pcie_root_port.c
>> @@ -54,6 +54,7 @@ static const VMStateDescription vmstate_rp_dev = {
>> VMSTATE_PCI_DEVICE(parent_obj.parent_obj.parent_obj, PCIESlot),
>> VMSTATE_STRUCT(parent_obj.parent_obj.parent_obj.exp.aer_log,
>> PCIESlot, 0, vmstate_pcie_aer_log, PCIEAERLog),
>> + VMSTATE_MSIX(parent_obj.parent_obj, PCIEPort),
>
> That will cause a failure of migration from/to 2.9.
> Doesn't that need to be tied to the machine-type in a subsection?
>
Hi Dave,
Thanks for the review,
I'll repost with the fix.
Thanks,
Marcel
> Dave
>
>> VMSTATE_END_OF_LIST()
>> }
>> };
>> --
>> 2.9.4
>>
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-07 11:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-07 10:24 [Qemu-devel] [PATCH] hw/pcie: fix the generic pcie root port to support migration Marcel Apfelbaum
2017-06-07 10:27 ` Dr. David Alan Gilbert
2017-06-07 11:09 ` Marcel Apfelbaum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).