From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIZ3F-0004yh-5o for qemu-devel@nongnu.org; Wed, 07 Jun 2017 07:23:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIZ3C-0000t9-1p for qemu-devel@nongnu.org; Wed, 07 Jun 2017 07:23:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40968) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dIZ3B-0000st-Rc for qemu-devel@nongnu.org; Wed, 07 Jun 2017 07:22:57 -0400 Date: Wed, 7 Jun 2017 12:22:53 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170607112252.GD2099@work-vm> References: <20170606165510.33057-1-pasic@linux.vnet.ibm.com> <20170606165510.33057-4-pasic@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170606165510.33057-4-pasic@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH 3/3] s390x/css: add hint for devno missmatch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic Cc: Christian Borntraeger , "Jason J . Herne" , Juan Quintela , qemu-devel@nongnu.org * Halil Pasic (pasic@linux.vnet.ibm.com) wrote: > This one has to be fixed up to 's390x: vmstatify config migration for > virtio-ccw' provided we want to achieve the same as 's390x/css: catch > section mismatch on load' does. > > Signed-off-by: Halil Pasic > --- > > This is on tom of 's390x: vmstatify config migration for virtio-ccw' p > which ain't on top of 's390x/css: catch section mismatch on load' but on > top of master. I kind of have a circular dependency here. This is why > the series is RFC. > > Wanted to provide an usage example. Faked 'Re: ' so patchew does not > try to apply this on top of current master. > --- > hw/s390x/css.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/hw/s390x/css.c b/hw/s390x/css.c > index 348129e1b2..de277d6a3d 100644 > --- a/hw/s390x/css.c > +++ b/hw/s390x/css.c > @@ -134,6 +134,10 @@ static const VMStateDescription vmstate_sense_id = { > static int subch_dev_post_load(void *opaque, int version_id); > static void subch_dev_pre_save(void *opaque); > > +const char err_hint_devno[] = "Devno mismatch, tried to load wrong section!" > + " Likely reason: some sequences of plug and unplug can break" > + " migration for machine versions prior to 2.7 (known design flaw)."; > + That's ok, but I suggest: * 'bug' rather than 'design flaw' - it sounds a bit less scary to endusers. Other than that, Reviewed-by: Dr. David Alan Gilbert Dave > const VMStateDescription vmstate_subch_dev = { > .name = "s390_subch_dev", > .version_id = 1, > @@ -144,7 +148,7 @@ const VMStateDescription vmstate_subch_dev = { > VMSTATE_UINT8_EQUAL(cssid, SubchDev), > VMSTATE_UINT8_EQUAL(ssid, SubchDev), > VMSTATE_UINT16(migrated_schid, SubchDev), > - VMSTATE_UINT16(devno, SubchDev), > + VMSTATE_UINT16_EQUAL_HINT(devno, SubchDev, err_hint_devno), > VMSTATE_BOOL(thinint_active, SubchDev), > VMSTATE_STRUCT(curr_status, SubchDev, 0, vmstate_schib, SCHIB), > VMSTATE_UINT8_ARRAY(sense_data, SubchDev, 32), > -- > 2.11.2 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK