qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: cota@braap.org
Subject: [Qemu-devel] [PATCH v4 3/7] tcg/aarch64: Use ADR in tcg_out_movi
Date: Wed,  7 Jun 2017 08:55:32 -0700	[thread overview]
Message-ID: <20170607155536.1193-4-rth@twiddle.net> (raw)
In-Reply-To: <20170607155536.1193-1-rth@twiddle.net>

The new placement of the TB means that we can use one insn
to load the return value for exit_tb returning the TB pointer.
---
 tcg/aarch64/tcg-target.inc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c
index 5f18545..1fa3bcc 100644
--- a/tcg/aarch64/tcg-target.inc.c
+++ b/tcg/aarch64/tcg-target.inc.c
@@ -616,7 +616,12 @@ static void tcg_out_movi(TCGContext *s, TCGType type, TCGReg rd,
     /* Look for host pointer values within 4G of the PC.  This happens
        often when loading pointers to QEMU's own data structures.  */
     if (type == TCG_TYPE_I64) {
-        tcg_target_long disp = (value >> 12) - ((intptr_t)s->code_ptr >> 12);
+        tcg_target_long disp = value - (intptr_t)s->code_ptr;
+        if (disp == sextract64(disp, 0, 21)) {
+            tcg_out_insn(s, 3406, ADR, rd, disp);
+            return;
+        }
+        disp = (value >> 12) - ((intptr_t)s->code_ptr >> 12);
         if (disp == sextract64(disp, 0, 21)) {
             tcg_out_insn(s, 3406, ADRP, rd, disp);
             if (value & 0xfff) {
-- 
2.9.4

  parent reply	other threads:[~2017-06-07 15:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07 15:55 [Qemu-devel] [PATCH v4 0/7] tcg: allocate TB structs preceding translate Richard Henderson
2017-06-07 15:55 ` [Qemu-devel] [PATCH v4 1/7] util: add cacheinfo Richard Henderson
2017-06-07 22:11   ` Emilio G. Cota
2017-06-08 16:42     ` Richard Henderson
2017-06-07 15:55 ` [Qemu-devel] [PATCH v4 2/7] tcg: allocate TB structs before the corresponding translated code Richard Henderson
2017-06-07 15:55 ` Richard Henderson [this message]
2017-06-07 15:55 ` [Qemu-devel] [PATCH v4 4/7] target/arm: Use indirect branch for goto_tb Richard Henderson
2017-06-07 15:55 ` [Qemu-devel] [PATCH v4 5/7] target/arm: Remove limit on code buffer size Richard Henderson
2017-06-07 15:55 ` [Qemu-devel] [PATCH v4 6/7] target/arm: Try pc-relative addresses for movi Richard Henderson
2017-06-07 15:55 ` [Qemu-devel] [PATCH v4 7/7] target/arm: Use ldr (literal) for goto_tb Richard Henderson
2017-06-07 19:46 ` [Qemu-devel] [PATCH v4 0/7] tcg: allocate TB structs preceding translate no-reply
2017-06-07 23:30 ` Emilio G. Cota
2017-06-08 16:44   ` Richard Henderson
2017-06-08 17:44     ` Emilio G. Cota
2017-06-08 20:17       ` Richard Henderson
2017-06-08  0:02 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607155536.1193-4-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=cota@braap.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).