From: Manos Pitsidianakis <el13635@mail.ntua.gr>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, stefanha@gmail.com,
berto@igalia.com
Subject: Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver
Date: Wed, 7 Jun 2017 19:06:28 +0300 [thread overview]
Message-ID: <20170607160628.mqhecliq7ka4t3gf@postretch> (raw)
In-Reply-To: <b1464fa9-84fe-780c-ea32-bbaa631b1d8f@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 584 bytes --]
On Wed, Jun 07, 2017 at 10:40:08AM -0500, Eric Blake wrote:
>On 06/07/2017 08:06 AM, Manos Pitsidianakis wrote:
>> This is part of my work for my GSOC project this summer.
>>
>> I am not sure if the count parameter in bdrv_co_pwrite_zeros and
>> bdrv_co_pdiscard refers to sectors or bytes.
>
>Both refer to byte counts. (We're trying to get rid of as many
>sector-based interfaces as possible, but it's slow going to make sure
>the conversions are still accurate).
I see. Would changing the names in the BlockDriverState function
signatures to reflect that be okay?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-06-07 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 13:06 [Qemu-devel] [PATCH RFC] block: add throttle block filter driver Manos Pitsidianakis
2017-06-07 15:40 ` Eric Blake
2017-06-07 16:06 ` Manos Pitsidianakis [this message]
2017-06-07 21:38 ` Eric Blake
2017-06-07 22:08 ` Manos Pitsidianakis
2017-06-07 22:19 ` Eric Blake
2017-06-08 7:22 ` Stefan Hajnoczi
2017-06-08 7:41 ` Manos Pitsidianakis
2017-06-08 10:32 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607160628.mqhecliq7ka4t3gf@postretch \
--to=el13635@mail.ntua.gr \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).