From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIgRm-00045A-F2 for qemu-devel@nongnu.org; Wed, 07 Jun 2017 15:16:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIgRj-0006VW-9p for qemu-devel@nongnu.org; Wed, 07 Jun 2017 15:16:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52306) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dIgRj-0006UV-1E for qemu-devel@nongnu.org; Wed, 07 Jun 2017 15:16:47 -0400 Date: Wed, 7 Jun 2017 20:16:38 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170607191638.GG2384@work-vm> References: <20170605004701.31891-1-sjitindarsingh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170605004701.31891-1-sjitindarsingh@gmail.com> Subject: Re: [Qemu-devel] [PATCH] monitor: Add -a (all) option to info registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Suraj Jitindar Singh Cc: qemu-devel@nongnu.org, armbru@redhat.com * Suraj Jitindar Singh (sjitindarsingh@gmail.com) wrote: > The info registers command in the qemu monitor is used to dump register > values. > > Currently this command uses the monitor cpu (which can be set by the > user) as the cpu for whose registers will be dumped. Sometimes it is > useful to see the registers for all cpus and currently this requires > setting the monitor cpu and the re-running the command for each cpu > in the system. I would be nice if there was an easier way to do this. > > Add the "-a" option to the info registers command to dump the register > values for all cpus. > > Signed-off-by: Suraj Jitindar Singh Hi Suraj, That looks pretty good, one minor suggestion below > --- > hmp-commands-info.hx | 6 +++--- > monitor.c | 20 +++++++++++++++----- > 2 files changed, 18 insertions(+), 8 deletions(-) > > diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx > index ae16901..ba98e58 100644 > --- a/hmp-commands-info.hx > +++ b/hmp-commands-info.hx > @@ -100,9 +100,9 @@ ETEXI > > { > .name = "registers", > - .args_type = "", > - .params = "", > - .help = "show the cpu registers", > + .args_type = "cpustate_all:-a", > + .params = "[-a]", > + .help = "show the cpu registers (-a: all - show register info for all cpus)", > .cmd = hmp_info_registers, > }, > > diff --git a/monitor.c b/monitor.c > index baa73c9..5875f88 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1078,13 +1078,23 @@ int monitor_get_cpu_index(void) > > static void hmp_info_registers(Monitor *mon, const QDict *qdict) > { > - CPUState *cs = mon_get_cpu(); > + bool all_cpus = qdict_get_try_bool(qdict, "cpustate_all", false); > + CPUState *cs; > > - if (!cs) { > - monitor_printf(mon, "No CPU available\n"); > - return; > + if (all_cpus) { > + CPU_FOREACH(cs) { Could we add a monitor_printf here giving the CPU number ? It would just make it a little easier when you have big list of CPUs and each has lots of registers to be able to see which one you're looking at. Thanks, Dave > + cpu_dump_state(cs, (FILE *)mon, monitor_fprintf, CPU_DUMP_FPU); > + } > + } else { > + cs = mon_get_cpu(); > + > + if (!cs) { > + monitor_printf(mon, "No CPU available\n"); > + return; > + } > + > + cpu_dump_state(cs, (FILE *)mon, monitor_fprintf, CPU_DUMP_FPU); > } > - cpu_dump_state(cs, (FILE *)mon, monitor_fprintf, CPU_DUMP_FPU); > } > > static void hmp_info_jit(Monitor *mon, const QDict *qdict) > -- > 2.9.4 Dave > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK