From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jonathon Jongsma <jjongsma@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 2/7] spice: Use proper enum type for kbd led state
Date: Thu, 8 Jun 2017 09:07:11 +0200 [thread overview]
Message-ID: <20170608070716.2954-3-kraxel@redhat.com> (raw)
In-Reply-To: <20170608070716.2954-1-kraxel@redhat.com>
From: Jonathon Jongsma <jjongsma@redhat.com>
Although the Qemu and spice flags currently have the same value, it
seems more correct to pass the spice flag values to
spice_server_kbd_leds(), especially considering that this function
already makes an effort to convert between the QEMU_*_LED and
SPICE_KEYBOARD_MODIFIER_* values.
Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20170510202006.31737-1-jjongsma@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/spice-input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/spice-input.c b/ui/spice-input.c
index 86293dd2ce..918580239d 100644
--- a/ui/spice-input.c
+++ b/ui/spice-input.c
@@ -87,7 +87,7 @@ static void kbd_leds(void *opaque, int ledstate)
if (ledstate & QEMU_CAPS_LOCK_LED) {
kbd->ledstate |= SPICE_KEYBOARD_MODIFIER_FLAGS_CAPS_LOCK;
}
- spice_server_kbd_leds(&kbd->sin, ledstate);
+ spice_server_kbd_leds(&kbd->sin, kbd->ledstate);
}
/* mouse bits */
--
2.9.3
next prev parent reply other threads:[~2017-06-08 7:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 7:07 [Qemu-devel] [PULL 0/7] ui patch queue Gerd Hoffmann
2017-06-08 7:07 ` [Qemu-devel] [PULL 1/7] Improve Cocoa modifier key handling Gerd Hoffmann
2017-06-08 7:07 ` Gerd Hoffmann [this message]
2017-06-08 7:07 ` [Qemu-devel] [PULL 3/7] gtk: prefer gtk3 over gtk2 Gerd Hoffmann
2017-06-08 7:07 ` [Qemu-devel] [PULL 4/7] sdl: prefer sdl2 over sdl1 Gerd Hoffmann
2017-06-08 7:07 ` [Qemu-devel] [PULL 5/7] gtk: add deprecation warning for gtk2 Gerd Hoffmann
2017-06-08 7:07 ` [Qemu-devel] [PULL 6/7] sdl: add deprecation warning for sdl1 Gerd Hoffmann
2017-06-08 7:07 ` [Qemu-devel] [PULL 7/7] spice: don't enter opengl mode in case another UI provides opengl support Gerd Hoffmann
2017-06-12 18:00 ` [Qemu-devel] [PULL 0/7] ui patch queue Peter Maydell
2017-06-12 18:08 ` Peter Maydell
2017-06-13 5:14 ` Thomas Huth
2017-06-13 8:26 ` Peter Maydell
2017-06-13 10:41 ` Gerd Hoffmann
2017-06-15 12:41 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170608070716.2954-3-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=jjongsma@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).