qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL v3 19/23] migration/block: reset dirty bitmap before reading
Date: Thu,  8 Jun 2017 19:56:39 +0800	[thread overview]
Message-ID: <20170608115643.18859-20-famz@redhat.com> (raw)
In-Reply-To: <20170608115643.18859-1-famz@redhat.com>

From: Paolo Bonzini <pbonzini@redhat.com>

Any data that is returned by read may be stale already, the bitmap
has to be cleared before issuing the read.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20170605123908.18777-16-pbonzini@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 migration/block.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/migration/block.c b/migration/block.c
index 0b3926e..7ed42c6 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -537,6 +537,8 @@ static int mig_save_device_dirty(QEMUFile *f, BlkMigDevState *bmds,
             } else {
                 nr_sectors = BDRV_SECTORS_PER_DIRTY_CHUNK;
             }
+            bdrv_reset_dirty_bitmap(bmds->dirty_bitmap, sector, nr_sectors);
+
             blk = g_new(BlkMigBlock, 1);
             blk->buf = g_malloc(BLOCK_SIZE);
             blk->bmds = bmds;
@@ -569,7 +571,6 @@ static int mig_save_device_dirty(QEMUFile *f, BlkMigDevState *bmds,
                 g_free(blk);
             }
 
-            bdrv_reset_dirty_bitmap(bmds->dirty_bitmap, sector, nr_sectors);
             sector += nr_sectors;
             bmds->cur_dirty = sector;
 
-- 
2.9.4

  parent reply	other threads:[~2017-06-08 11:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08 11:56 [Qemu-devel] [PULL v3 00/23] Docker and block patches Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 01/23] docker: Run tests with current user Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 02/23] docker: Add bzip2 and hostname to fedora image Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 03/23] docker: Add libaio " Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 04/23] docker: Add flex and bison to centos6 image Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 05/23] block: access copy_on_read with atomic ops Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 06/23] block: access quiesce_counter " Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 07/23] block: access io_limits_disabled " Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 08/23] block: access serialising_in_flight " Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 09/23] block: access wakeup " Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 10/23] block: access io_plugged " Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 11/23] throttle-groups: only start one coroutine from drained_begin Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 12/23] throttle-groups: do not use qemu_co_enter_next Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 13/23] throttle-groups: protect throttled requests with a CoMutex Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 14/23] util: add stats64 module Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 15/23] block: use Stat64 for wr_highest_offset Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 16/23] block: access write_gen with atomics Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 17/23] block: protect tracked_requests and flush_queue with reqs_lock Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 18/23] block: introduce dirty_bitmap_mutex Fam Zheng
2017-06-16  0:12   ` Fam Zheng
2017-06-08 11:56 ` Fam Zheng [this message]
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 20/23] block: protect modification of dirty bitmaps with a mutex Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 21/23] block: introduce block_account_one_io Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 22/23] block: split BlockAcctStats creation and setup Fam Zheng
2017-06-08 11:56 ` [Qemu-devel] [PULL v3 23/23] block: make accounting thread-safe Fam Zheng
2017-06-12 18:26 ` [Qemu-devel] [PULL v3 00/23] Docker and block patches Peter Maydell
2017-06-14 11:04   ` Fam Zheng
2017-06-14 11:22     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170608115643.18859-20-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).