[Qemu-devel] 答复: Re: [PATCHv2 04/04] colo-compare: Update the COLO document to fix theprocessing of secondary packets in the main thread

[<wang.yong155@zte.com.cn>]

＞＞ From: Wang Yong ＜wang.yong155@zte.com.cn＞

＞＞

＞＞ In my test, secondary does not process the packets comparing in the IOThread

＞＞ but in the qemu main thread processing.

＞＞ secondary's configuration " -chardev socket,id=compare1,host=3.3.3.3,port=9004,server,nowait"

＞＞ here,we should use 'wait' instead of 'nowait' configuration .

＞＞ after use  'wait' configuration ,packets can be process in the IOThread from the secondary,

＞＞ not in the qemu main thread.

＞＞

＞＞ Signed-off-by: Wang Yong＜wang.yong155@zte.com.cn＞

＞＞ Signed-off-by: Wang Guang＜wang.guang55@zte.com.cn＞

＞＞ ---




＞This is a hint probably for something wrong in the code. Need to figure 

＞out the root cause.




I think this is not a BUG but configuration problem.

then this series can not submit this patch.




Thanks




＞Thanks




＞＞   docs/colo-proxy.txt | 2 +-

＞＞   1 file changed, 1 insertion(+), 1 deletion(-)

＞＞

＞＞ diff --git a/docs/colo-proxy.txt b/docs/colo-proxy.txt

＞＞ index ce3f783..567cc8b 100644

＞＞ --- a/docs/colo-proxy.txt

＞＞ +++ b/docs/colo-proxy.txt

＞＞ @@ -165,7 +165,7 @@ Primary(ip:3.3.3.3):

＞＞   -netdev tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown

＞＞   -device e1000,id=e0,netdev=hn0,mac=52:a4:00:12:78:66

＞＞   -chardev socket,id=mirror0,host=3.3.3.3,port=9003,server,nowait

＞＞ --chardev socket,id=compare1,host=3.3.3.3,port=9004,server,nowait

＞＞ +-chardev socket,id=compare1,host=3.3.3.3,port=9004,server,wait

＞＞   -chardev socket,id=compare0,host=3.3.3.3,port=9001,server,nowait

＞＞   -chardev socket,id=compare0-0,host=3.3.3.3,port=9001

＞＞   -chardev socket,id=compare_out,host=3.3.3.3,port=9005,server,nowai















原始邮件



发件人： ＜jasowang@redhat.com＞
收件人：王勇10170530 ＜zhang.zhanghailiang@huawei.com＞ ＜zhangchen.fnst@cn.fujitsu.com＞
抄送人： ＜lizhijian@cn.fujitsu.com＞ ＜qemu-devel@nongnu.org＞王广10165992
日 期 ：2017年06月07日 16:37
主 题 ：Re: [PATCHv2 04/04] colo-compare: Update the COLO document to fix theprocessing of secondary packets in the main thread







On 2017年06月05日 18:44, Yong Wang wrote:
＞ From: Wang Yong ＜wang.yong155@zte.com.cn＞
＞
＞ In my test, secondary does not process the packets comparing in the IOThread
＞ but in the qemu main thread processing.
＞ secondary's configuration " -chardev socket,id=compare1,host=3.3.3.3,port=9004,server,nowait"
＞ here,we should use 'wait' instead of 'nowait' configuration .
＞ after use  'wait' configuration ,packets can be process in the IOThread from the secondary,
＞ not in the qemu main thread.
＞
＞ Signed-off-by: Wang Yong＜wang.yong155@zte.com.cn＞
＞ Signed-off-by: Wang Guang＜wang.guang55@zte.com.cn＞
＞ ---

This is a hint probably for something wrong in the code. Need to figure 
out the root cause.

Thanks

＞   docs/colo-proxy.txt | 2 +-
＞   1 file changed, 1 insertion(+), 1 deletion(-)
＞
＞ diff --git a/docs/colo-proxy.txt b/docs/colo-proxy.txt
＞ index ce3f783..567cc8b 100644
＞ --- a/docs/colo-proxy.txt
＞ +++ b/docs/colo-proxy.txt
＞ @@ -165,7 +165,7 @@ Primary(ip:3.3.3.3):
＞   -netdev tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown
＞   -device e1000,id=e0,netdev=hn0,mac=52:a4:00:12:78:66
＞   -chardev socket,id=mirror0,host=3.3.3.3,port=9003,server,nowait
＞ --chardev socket,id=compare1,host=3.3.3.3,port=9004,server,nowait
＞ +-chardev socket,id=compare1,host=3.3.3.3,port=9004,server,wait
＞   -chardev socket,id=compare0,host=3.3.3.3,port=9001,server,nowait
＞   -chardev socket,id=compare0-0,host=3.3.3.3,port=9001
＞   -chardev socket,id=compare_out,host=3.3.3.3,port=9005,server,nowait