* [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object
@ 2017-06-08 13:18 Thomas Huth
2017-06-08 14:23 ` Juan Quintela
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2017-06-08 13:18 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Bharata B Rao, Eduardo Habkost,
Igor Mammedov, David Gibson, Juan Quintela, Andrew Jones
There does not seem to be any target specific code in core.c, so we can
put it into "common-obj" instead of "obj" to compile it only once for
all targets.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/cpu/Makefile.objs | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/cpu/Makefile.objs b/hw/cpu/Makefile.objs
index 942a4bb..cd52d20 100644
--- a/hw/cpu/Makefile.objs
+++ b/hw/cpu/Makefile.objs
@@ -2,5 +2,4 @@ obj-$(CONFIG_ARM11MPCORE) += arm11mpcore.o
obj-$(CONFIG_REALVIEW) += realview_mpcore.o
obj-$(CONFIG_A9MPCORE) += a9mpcore.o
obj-$(CONFIG_A15MPCORE) += a15mpcore.o
-obj-y += core.o
-
+common-obj-y += core.o
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object
2017-06-08 13:18 [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object Thomas Huth
@ 2017-06-08 14:23 ` Juan Quintela
2017-06-09 2:03 ` David Gibson
0 siblings, 1 reply; 4+ messages in thread
From: Juan Quintela @ 2017-06-08 14:23 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, qemu-trivial, Paolo Bonzini, Bharata B Rao,
Eduardo Habkost, Igor Mammedov, David Gibson, Andrew Jones
Thomas Huth <thuth@redhat.com> wrote:
> There does not seem to be any target specific code in core.c, so we can
> put it into "common-obj" instead of "obj" to compile it only once for
> all targets.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
It compiles.
I can't see anything that is target dependent on core.c.
So
Reviewed-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object
2017-06-08 14:23 ` Juan Quintela
@ 2017-06-09 2:03 ` David Gibson
2017-06-09 13:20 ` Eduardo Habkost
0 siblings, 1 reply; 4+ messages in thread
From: David Gibson @ 2017-06-09 2:03 UTC (permalink / raw)
To: Juan Quintela
Cc: Thomas Huth, qemu-devel, qemu-trivial, Paolo Bonzini,
Bharata B Rao, Eduardo Habkost, Igor Mammedov, Andrew Jones
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
On Thu, Jun 08, 2017 at 04:23:34PM +0200, Juan Quintela wrote:
> Thomas Huth <thuth@redhat.com> wrote:
> > There does not seem to be any target specific code in core.c, so we can
> > put it into "common-obj" instead of "obj" to compile it only once for
> > all targets.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> It compiles.
> I can't see anything that is target dependent on core.c.
>
> So
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
I've merged this into my ppc-for-2.10 tree, on the basis that ppc is
the only user of core.c so far. Any objections?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object
2017-06-09 2:03 ` David Gibson
@ 2017-06-09 13:20 ` Eduardo Habkost
0 siblings, 0 replies; 4+ messages in thread
From: Eduardo Habkost @ 2017-06-09 13:20 UTC (permalink / raw)
To: David Gibson
Cc: Juan Quintela, Thomas Huth, qemu-devel, qemu-trivial,
Paolo Bonzini, Bharata B Rao, Igor Mammedov, Andrew Jones
On Fri, Jun 09, 2017 at 12:03:38PM +1000, David Gibson wrote:
> On Thu, Jun 08, 2017 at 04:23:34PM +0200, Juan Quintela wrote:
> > Thomas Huth <thuth@redhat.com> wrote:
> > > There does not seem to be any target specific code in core.c, so we can
> > > put it into "common-obj" instead of "obj" to compile it only once for
> > > all targets.
> > >
> > > Signed-off-by: Thomas Huth <thuth@redhat.com>
> >
> > It compiles.
> > I can't see anything that is target dependent on core.c.
> >
> > So
> >
> > Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> I've merged this into my ppc-for-2.10 tree, on the basis that ppc is
> the only user of core.c so far. Any objections?
No problem to me. If you want, you can add my:
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-09 13:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-08 13:18 [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object Thomas Huth
2017-06-08 14:23 ` Juan Quintela
2017-06-09 2:03 ` David Gibson
2017-06-09 13:20 ` Eduardo Habkost
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).