From: "Emilio G. Cota" <cota@braap.org>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 0/7] tcg: allocate TB structs preceding translate
Date: Fri, 9 Jun 2017 16:16:22 -0400 [thread overview]
Message-ID: <20170609201622.GA28180@flamenco> (raw)
In-Reply-To: <18d9fd86-d190-cc2c-99dc-e304b6f71275@twiddle.net>
On Fri, Jun 09, 2017 at 12:58:17 -0700, Richard Henderson wrote:
> >>=== OUTPUT BEGIN ===
> >>Checking PATCH 1/7: util: add cacheinfo...
> >>ERROR: do not initialise globals to 0 or NULL
> >>#149: FILE: util/cacheinfo.c:11:
> >>+int qemu_icache_linesize = 0;
> >>
> >>ERROR: do not initialise globals to 0 or NULL
> >>#150: FILE: util/cacheinfo.c:12:
> >>+int qemu_dcache_linesize = 0;
>
> These are bogus checkpatch warnings. If we really want this, we should also
> use -fno-common. But without that, there is a real difference between
> initialized and non-initialized global variables.
>
> >>
> >>ERROR: space prohibited after that '&&' (ctx:ExW)
> >>#191: FILE: util/cacheinfo.c:53:
> >>+ && buf[i].Cache.Level == 1) {
> >> ^
>
> This is also bogus. I have no idea what it's attempting to detect.
I think this one is just enforcing a certain coding style convention;
"A &&\nB" will pass but "A\n&&B" won't.
E.
next prev parent reply other threads:[~2017-06-09 20:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 5:37 [Qemu-devel] [PATCH v5 0/7] tcg: allocate TB structs preceding translate Richard Henderson
2017-06-09 5:37 ` [Qemu-devel] [PATCH v5 1/7] util: add cacheinfo Richard Henderson
2017-06-09 5:37 ` [Qemu-devel] [PATCH v5 2/7] tcg: allocate TB structs before the corresponding translated code Richard Henderson
2017-06-09 5:37 ` [Qemu-devel] [PATCH v5 3/7] tcg/aarch64: Use ADR in tcg_out_movi Richard Henderson
2017-06-09 5:37 ` [Qemu-devel] [PATCH v5 4/7] tcg/arm: Use indirect branch for goto_tb Richard Henderson
2017-06-09 5:37 ` [Qemu-devel] [PATCH v5 5/7] tcg/arm: Remove limit on code buffer size Richard Henderson
2017-06-09 5:37 ` [Qemu-devel] [PATCH v5 6/7] tcg/arm: Try pc-relative addresses for movi Richard Henderson
2017-06-09 5:37 ` [Qemu-devel] [PATCH v5 7/7] tcg/arm: Use ldr (literal) for goto_tb Richard Henderson
2017-06-09 7:00 ` [Qemu-devel] [PATCH v5 0/7] tcg: allocate TB structs preceding translate no-reply
2017-06-09 19:52 ` Emilio G. Cota
2017-06-09 19:55 ` [Qemu-devel] [PATCH] translate-all: consolidate tb init in tb_gen_code Emilio G. Cota
2017-06-09 19:58 ` [Qemu-devel] [PATCH v5 0/7] tcg: allocate TB structs preceding translate Richard Henderson
2017-06-09 20:16 ` Emilio G. Cota [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-09 5:36 Richard Henderson
2017-06-09 5:36 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609201622.GA28180@flamenco \
--to=cota@braap.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).