* [Qemu-devel] [PATCH] tcg/tci: enable bswap16_i64
@ 2017-06-10 22:31 Philippe Mathieu-Daudé
2017-06-13 19:11 ` Alex Bennée
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-06-10 22:31 UTC (permalink / raw)
To: qemu-devel, Alex Bennée, Emilio G . Cota, Richard Henderson
Cc: Philippe Mathieu-Daudé
remove some copy/paste leftover, code seems sane.
while running Alex Bennée's image aarch64-linux-3.15rc2-buildroot.img:
Trace 0x7fa1904b0890 [0: ffffffc00036cd04]
----------------
IN:
0xffffffc00036cd24: 5ac00694 rev16 w20, w20
OP:
---- ffffffc00036cd24 0000000000000000 0000000000000000
ext32u_i64 tmp3,x20
ext16u_i64 tmp2,tmp3
bswap16_i64 x20,tmp2
movi_i64 tmp4,$0x10
shr_i64 tmp2,tmp3,tmp4
ext16u_i64 tmp2,tmp2
bswap16_i64 tmp2,tmp2
deposit_i64 x20,x20,tmp2,$0x10,$0x10
Linking TBs 0x7fa1904b0890 [ffffffc00036cd04] index 0 -> 0x7fa1904b0aa0 [ffffffc00036cd24]
Trace 0x7fa1904b0aa0 [0: ffffffc00036cd24]
TODO qemu/tci.c:1049: tcg_qemu_tb_exec()
qemu/tci.c:1049: tcg fatal error
Aborted
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
there is no entry in MAINTAINERS for this file, I think it should it go under:
"Tiny Code Generator (TCG) / Common code"
tci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tci.c b/tci.c
index 4bdc645f2a..f39bfb95c0 100644
--- a/tci.c
+++ b/tci.c
@@ -1046,7 +1046,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
break;
#if TCG_TARGET_HAS_bswap16_i64
case INDEX_op_bswap16_i64:
- TODO();
t0 = *tb_ptr++;
t1 = tci_read_r16(&tb_ptr);
tci_write_reg64(t0, bswap16(t1));
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] tcg/tci: enable bswap16_i64
2017-06-10 22:31 [Qemu-devel] [PATCH] tcg/tci: enable bswap16_i64 Philippe Mathieu-Daudé
@ 2017-06-13 19:11 ` Alex Bennée
2017-06-19 21:35 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Alex Bennée @ 2017-06-13 19:11 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel, Emilio G . Cota, Richard Henderson
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> remove some copy/paste leftover, code seems sane.
>
> while running Alex Bennée's image aarch64-linux-3.15rc2-buildroot.img:
>
> Trace 0x7fa1904b0890 [0: ffffffc00036cd04]
> ----------------
> IN:
> 0xffffffc00036cd24: 5ac00694 rev16 w20, w20
>
> OP:
> ---- ffffffc00036cd24 0000000000000000 0000000000000000
> ext32u_i64 tmp3,x20
> ext16u_i64 tmp2,tmp3
> bswap16_i64 x20,tmp2
> movi_i64 tmp4,$0x10
> shr_i64 tmp2,tmp3,tmp4
> ext16u_i64 tmp2,tmp2
> bswap16_i64 tmp2,tmp2
> deposit_i64 x20,x20,tmp2,$0x10,$0x10
>
> Linking TBs 0x7fa1904b0890 [ffffffc00036cd04] index 0 -> 0x7fa1904b0aa0 [ffffffc00036cd24]
> Trace 0x7fa1904b0aa0 [0: ffffffc00036cd24]
> TODO qemu/tci.c:1049: tcg_qemu_tb_exec()
> qemu/tci.c:1049: tcg fatal error
> Aborted
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Possibly the only person who has run tci recently ;-)
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>
> there is no entry in MAINTAINERS for this file, I think it should it go under:
> "Tiny Code Generator (TCG) / Common code"
>
> tci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tci.c b/tci.c
> index 4bdc645f2a..f39bfb95c0 100644
> --- a/tci.c
> +++ b/tci.c
> @@ -1046,7 +1046,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
> break;
> #if TCG_TARGET_HAS_bswap16_i64
> case INDEX_op_bswap16_i64:
> - TODO();
> t0 = *tb_ptr++;
> t1 = tci_read_r16(&tb_ptr);
> tci_write_reg64(t0, bswap16(t1));
--
Alex Bennée
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg/tci: enable bswap16_i64
2017-06-13 19:11 ` Alex Bennée
@ 2017-06-19 21:35 ` Richard Henderson
0 siblings, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2017-06-19 21:35 UTC (permalink / raw)
To: Alex Bennée, Philippe Mathieu-Daudé; +Cc: Emilio G . Cota, qemu-devel
On 06/13/2017 12:11 PM, Alex Bennée wrote:
>
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
>
>> remove some copy/paste leftover, code seems sane.
>>
>> while running Alex Bennée's image aarch64-linux-3.15rc2-buildroot.img:
>>
>> Trace 0x7fa1904b0890 [0: ffffffc00036cd04]
>> ----------------
>> IN:
>> 0xffffffc00036cd24: 5ac00694 rev16 w20, w20
>>
>> OP:
>> ---- ffffffc00036cd24 0000000000000000 0000000000000000
>> ext32u_i64 tmp3,x20
>> ext16u_i64 tmp2,tmp3
>> bswap16_i64 x20,tmp2
>> movi_i64 tmp4,$0x10
>> shr_i64 tmp2,tmp3,tmp4
>> ext16u_i64 tmp2,tmp2
>> bswap16_i64 tmp2,tmp2
>> deposit_i64 x20,x20,tmp2,$0x10,$0x10
>>
>> Linking TBs 0x7fa1904b0890 [ffffffc00036cd04] index 0 -> 0x7fa1904b0aa0 [ffffffc00036cd24]
>> Trace 0x7fa1904b0aa0 [0: ffffffc00036cd24]
>> TODO qemu/tci.c:1049: tcg_qemu_tb_exec()
>> qemu/tci.c:1049: tcg fatal error
>> Aborted
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Possibly the only person who has run tci recently ;-)
Is it time to remove it? I'm pretty sure the only hosts for which it will work
have proper backends...
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-19 21:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-10 22:31 [Qemu-devel] [PATCH] tcg/tci: enable bswap16_i64 Philippe Mathieu-Daudé
2017-06-13 19:11 ` Alex Bennée
2017-06-19 21:35 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).