From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/2] ram: Now POSTCOPY_ACTIVE is the same that STATUS_ACTIVE
Date: Mon, 12 Jun 2017 12:57:16 +0100 [thread overview]
Message-ID: <20170612115715.GE3146@work-vm> (raw)
In-Reply-To: <20170607105810.3003-3-quintela@redhat.com>
* Juan Quintela (quintela@redhat.com) wrote:
> Merge them.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/migration.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index cfa266b..b31a195 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -541,20 +541,8 @@ MigrationInfo *qmp_query_migrate(Error **errp)
> break;
> case MIGRATION_STATUS_ACTIVE:
> case MIGRATION_STATUS_CANCELLING:
> - info->has_status = true;
> - info->has_total_time = true;
> - info->total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME)
> - - s->total_time;
> - info->has_expected_downtime = true;
> - info->expected_downtime = s->expected_downtime;
> - info->has_setup_time = true;
> - info->setup_time = s->setup_time;
> -
> - populate_ram_info(info, s);
> - populate_disk_info(info);
> - break;
> case MIGRATION_STATUS_POSTCOPY_ACTIVE:
> - /* Mostly the same as active; TODO add some postcopy stats */
> + /* TODO add some postcopy stats */
> info->has_status = true;
> info->has_total_time = true;
> info->total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME)
> --
> 2.9.4
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2017-06-12 11:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 10:58 [Qemu-devel] [PATCH v2 0/2] Make info migrate output consistent Juan Quintela
2017-06-07 10:58 ` [Qemu-devel] [PATCH v2 1/2] ram: Print block stats also in the complete case Juan Quintela
2017-06-12 11:52 ` Dr. David Alan Gilbert
2017-06-12 11:58 ` Laurent Vivier
2017-06-07 10:58 ` [Qemu-devel] [PATCH v2 2/2] ram: Now POSTCOPY_ACTIVE is the same that STATUS_ACTIVE Juan Quintela
2017-06-12 11:57 ` Dr. David Alan Gilbert [this message]
2017-06-12 12:01 ` Laurent Vivier
2017-06-07 11:37 ` [Qemu-devel] [PATCH v2 0/2] Make info migrate output consistent Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612115715.GE3146@work-vm \
--to=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).