* [Qemu-devel] NVME: is there any plan to support SGL data transfer?
@ 2017-06-02 1:47 Qu Wenruo
2017-06-02 13:51 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
0 siblings, 1 reply; 5+ messages in thread
From: Qu Wenruo @ 2017-06-02 1:47 UTC (permalink / raw)
To: qemu-devel, qemu-block
Hi,
When going through NVMe specification and hw/block/nvme.c,
I found that it seems that NVMe qemu implementation only support PRP for
sq entry.
And NvmeRwCmd doesn't even use union to define DPTR, but just prp1 and prp2.
Although I am just a newbie, but I'm quite interested in NVMe and want
to try to implement SGL support for qemu NVMe.
Is there anyone already doing such work? Or is there any plan on
implement such feature?
Thanks,
Qu
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] NVME: is there any plan to support SGL data transfer?
2017-06-02 1:47 [Qemu-devel] NVME: is there any plan to support SGL data transfer? Qu Wenruo
@ 2017-06-02 13:51 ` Kevin Wolf
2017-06-12 14:05 ` Keith Busch
0 siblings, 1 reply; 5+ messages in thread
From: Kevin Wolf @ 2017-06-02 13:51 UTC (permalink / raw)
To: Qu Wenruo; +Cc: qemu-devel, qemu-block, keith.busch
Am 02.06.2017 um 03:47 hat Qu Wenruo geschrieben:
> When going through NVMe specification and hw/block/nvme.c,
> I found that it seems that NVMe qemu implementation only support PRP
> for sq entry.
> And NvmeRwCmd doesn't even use union to define DPTR, but just prp1 and prp2.
>
> Although I am just a newbie, but I'm quite interested in NVMe and
> want to try to implement SGL support for qemu NVMe.
>
> Is there anyone already doing such work? Or is there any plan on
> implement such feature?
Keith, you can probably answer this?
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] NVME: is there any plan to support SGL data transfer?
2017-06-02 13:51 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
@ 2017-06-12 14:05 ` Keith Busch
2017-06-13 1:25 ` Qu Wenruo
2017-06-13 1:27 ` Qu Wenruo
0 siblings, 2 replies; 5+ messages in thread
From: Keith Busch @ 2017-06-12 14:05 UTC (permalink / raw)
To: Kevin Wolf; +Cc: Qu Wenruo, qemu-devel, qemu-block
On Fri, Jun 02, 2017 at 03:51:51PM +0200, Kevin Wolf wrote:
> Am 02.06.2017 um 03:47 hat Qu Wenruo geschrieben:
> > When going through NVMe specification and hw/block/nvme.c,
> > I found that it seems that NVMe qemu implementation only support PRP
> > for sq entry.
> > And NvmeRwCmd doesn't even use union to define DPTR, but just prp1 and prp2.
> >
> > Although I am just a newbie, but I'm quite interested in NVMe and
> > want to try to implement SGL support for qemu NVMe.
> >
> > Is there anyone already doing such work? Or is there any plan on
> > implement such feature?
>
> Keith, you can probably answer this?
Hi,
I personally have no plans to implement it, but would be happy to see it
added if someone wants to send the patch for review.
Thanks,
Keith
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] NVME: is there any plan to support SGL data transfer?
2017-06-12 14:05 ` Keith Busch
@ 2017-06-13 1:25 ` Qu Wenruo
2017-06-13 1:27 ` Qu Wenruo
1 sibling, 0 replies; 5+ messages in thread
From: Qu Wenruo @ 2017-06-13 1:25 UTC (permalink / raw)
To: Keith Busch, Kevin Wolf; +Cc: qemu-devel, qemu-block
At 06/12/2017 10:05 PM, Keith Busch wrote:
> On Fri, Jun 02, 2017 at 03:51:51PM +0200, Kevin Wolf wrote:
>> Am 02.06.2017 um 03:47 hat Qu Wenruo geschrieben:
>>> When going through NVMe specification and hw/block/nvme.c,
>>> I found that it seems that NVMe qemu implementation only support PRP
>>> for sq entry.
>>> And NvmeRwCmd doesn't even use union to define DPTR, but just prp1 and prp2.
>>>
>>> Although I am just a newbie, but I'm quite interested in NVMe and
>>> want to try to implement SGL support for qemu NVMe.
>>>
>>> Is there anyone already doing such work? Or is there any plan on
>>> implement such feature?
>>
>> Keith, you can probably answer this?
>
> Hi,
>
> I personally have no plans to implement it, but would be happy to see it
> added if someone wants to send the patch for review.
Glad to hear that.
I have submitted some preparation patch to update nvme.h for SGL and
added needed error code for it.
It would be very nice if anyone could review it.
Thanks,
Qu
>
> Thanks,
> Keith
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] NVME: is there any plan to support SGL data transfer?
2017-06-12 14:05 ` Keith Busch
2017-06-13 1:25 ` Qu Wenruo
@ 2017-06-13 1:27 ` Qu Wenruo
1 sibling, 0 replies; 5+ messages in thread
From: Qu Wenruo @ 2017-06-13 1:27 UTC (permalink / raw)
To: Keith Busch, Kevin Wolf; +Cc: qemu-devel, qemu-block
At 06/12/2017 10:05 PM, Keith Busch wrote:
> On Fri, Jun 02, 2017 at 03:51:51PM +0200, Kevin Wolf wrote:
>> Am 02.06.2017 um 03:47 hat Qu Wenruo geschrieben:
>>> When going through NVMe specification and hw/block/nvme.c,
>>> I found that it seems that NVMe qemu implementation only support PRP
>>> for sq entry.
>>> And NvmeRwCmd doesn't even use union to define DPTR, but just prp1 and prp2.
>>>
>>> Although I am just a newbie, but I'm quite interested in NVMe and
>>> want to try to implement SGL support for qemu NVMe.
>>>
>>> Is there anyone already doing such work? Or is there any plan on
>>> implement such feature?
>>
>> Keith, you can probably answer this?
>
> Hi,
>
> I personally have no plans to implement it, but would be happy to see it
> added if someone wants to send the patch for review.
Glad to hear that.
I have already submitted preparation patch to update nvme.h for SGL
structures and introduced needed error code according to NVMe 1.3 spec.
It would be quite nice if anyone is interested in that patchset.
Thanks,
Qu
>
> Thanks,
> Keith
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-14 0:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-02 1:47 [Qemu-devel] NVME: is there any plan to support SGL data transfer? Qu Wenruo
2017-06-02 13:51 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2017-06-12 14:05 ` Keith Busch
2017-06-13 1:25 ` Qu Wenruo
2017-06-13 1:27 ` Qu Wenruo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).