From: Zhong Yang <yang.zhong@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, anthony.xu@intel.com, yang.zhong@intel.com
Subject: [Qemu-devel] About remove the TCG related code in hw/i386/kvmvapic.c!
Date: Wed, 14 Jun 2017 11:22:32 +0800 [thread overview]
Message-ID: <20170614032232.GA1330@yangzhon-Virtual> (raw)
Hello Paolo,
About you below A20 fixed patch has been merged in QEMU latest release,
commit bbfa326fc8028e275eddf8c9965c2a1b59405b2e
target/i386: enable A20 automatically in system management mod
I also disabled the kvmvapic rom with below patch and use qemu command to verify your patch
#disable kvmapic rom patch
diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
index 1ef56f8..72c5bd6 100644
--- a/hw/intc/apic_common.c
+++ b/hw/intc/apic_common.c
@@ -440,7 +440,7 @@ static const VMStateDescription vmstate_apic_common = {
static Property apic_properties_common[] = {
DEFINE_PROP_UINT8("version", APICCommonState, version, 0x14),
DEFINE_PROP_BIT("vapic", APICCommonState, vapic_control, VAPIC_ENABLE_BIT,
- true),
+ false),
DEFINE_PROP_BOOL("legacy-instance-id", APICCommonState, legacy_instance_id,
false),
DEFINE_PROP_END_OF_LIST(),
#the pure tcg to boot image
./qemu-system-x86_64 -m 2G -smp cpus=4,cores=4,threads=1,sockets=1 -drive format=raw,file=eywa.img,index=0,media=disk -nographic -serial stdio -nodefaults
The image can be booted up normally now.
This verification show the TCG related code in kvmvapic.c file are NOT useful, my plan is to delete those TCG code in kvmvapic.c file, what's your comments? Many thanks!
Regards,
Yang
reply other threads:[~2017-06-14 3:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614032232.GA1330@yangzhon-Virtual \
--to=yang.zhong@intel.com \
--cc=anthony.xu@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).