From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dL867-00064B-Mk for qemu-devel@nongnu.org; Wed, 14 Jun 2017 09:12:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dL866-0005DX-Ox for qemu-devel@nongnu.org; Wed, 14 Jun 2017 09:12:35 -0400 Date: Wed, 14 Jun 2017 14:12:25 +0100 From: "Richard W.M. Jones" Message-ID: <20170614131225.GB31999@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 0/2] Parse 'filename' option for RBD/iSCSI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, kwolf@redhat.com, mreitz@redhat.com On Wed, Jun 14, 2017 at 08:53:18AM -0400, Jeff Cody wrote: > Change from v2: > Add warning message that this is an unsupported option that may > be deprecated in the future. > > We need to be able to parse the 'filename' option for rbd and iscsi, because > there may exist images in the wild that have json backing files, that specify > the filename argument. > > Jeff Cody (2): > block/rbd: enable filename option and parsing > block/iscsi: enable filename option and parsing > > block/iscsi.c | 22 +++++++++++++++++++++- > block/rbd.c | 22 +++++++++++++++++++++- > 2 files changed, 42 insertions(+), 2 deletions(-) ACK series. Issuing the warning is a good idea too. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org