From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH 0/4] block: Don't compare strings in bdrv_reopen_prepare()
Date: Wed, 14 Jun 2017 17:30:58 +0200 [thread overview]
Message-ID: <20170614153102.9077-1-mreitz@redhat.com> (raw)
bdrv_reopen_prepare() assumes that all BDS options are strings, which is
not necessarily correct. This series introduces a new qobject_is_equal()
function which can be used to test whether any options have changed,
independently of their type.
Max Reitz (4):
qapi/qnull: Add own header
qapi: Add qobject_is_equal()
block: qobject_is_equal() in bdrv_reopen_prepare()
iotests: Add test for non-string option reopening
include/qapi/qmp/qbool.h | 1 +
include/qapi/qmp/qdict.h | 1 +
include/qapi/qmp/qfloat.h | 1 +
include/qapi/qmp/qint.h | 1 +
include/qapi/qmp/qlist.h | 1 +
include/qapi/qmp/qnull.h | 28 ++++++++++++++++++++++++++++
include/qapi/qmp/qobject.h | 17 +++++++++--------
include/qapi/qmp/qstring.h | 1 +
include/qapi/qmp/types.h | 1 +
block.c | 15 +++------------
qobject/qbool.c | 8 ++++++++
qobject/qdict.c | 24 ++++++++++++++++++++++++
qobject/qfloat.c | 8 ++++++++
qobject/qint.c | 8 ++++++++
qobject/qlist.c | 25 +++++++++++++++++++++++++
qobject/qnull.c | 6 ++++++
qobject/qobject.c | 30 ++++++++++++++++++++++++++++++
qobject/qstring.c | 9 +++++++++
target/i386/cpu.c | 6 +-----
tests/check-qnull.c | 2 +-
tests/qemu-iotests/133 | 9 +++++++++
tests/qemu-iotests/133.out | 5 +++++
22 files changed, 181 insertions(+), 26 deletions(-)
create mode 100644 include/qapi/qmp/qnull.h
--
2.9.4
next reply other threads:[~2017-06-14 15:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 15:30 Max Reitz [this message]
2017-06-14 15:30 ` [Qemu-devel] [PATCH 1/4] qapi/qnull: Add own header Max Reitz
2017-06-19 13:20 ` Kevin Wolf
2017-06-14 15:31 ` [Qemu-devel] [PATCH 2/4] qapi: Add qobject_is_equal() Max Reitz
2017-06-19 13:55 ` Kevin Wolf
2017-06-19 14:59 ` Max Reitz
2017-06-14 15:31 ` [Qemu-devel] [PATCH 3/4] block: qobject_is_equal() in bdrv_reopen_prepare() Max Reitz
2017-06-19 14:10 ` Kevin Wolf
2017-06-14 15:31 ` [Qemu-devel] [PATCH 4/4] iotests: Add test for non-string option reopening Max Reitz
2017-06-19 14:14 ` Kevin Wolf
2017-06-14 16:20 ` [Qemu-devel] [PATCH 0/4] block: Don't compare strings in bdrv_reopen_prepare() no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614153102.9077-1-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).