qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: david@redhat.com, aurelien@aurel32.net
Subject: [Qemu-devel] [PATCH 2/5] target/s390x: Enforce instruction features
Date: Wed, 14 Jun 2017 22:53:53 -0700	[thread overview]
Message-ID: <20170615055356.20684-3-rth@twiddle.net> (raw)
In-Reply-To: <20170615055356.20684-1-rth@twiddle.net>

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target/s390x/translate.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index af18ffb..48cee25 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -55,6 +55,7 @@ typedef struct DisasFields DisasFields;
 
 struct DisasContext {
     struct TranslationBlock *tb;
+    const unsigned long *features;
     const DisasInsn *insn;
     DisasFields *fields;
     uint64_t ex_value;
@@ -5600,6 +5601,12 @@ static ExitStatus translate_one(CPUS390XState *env, DisasContext *s)
     }
 #endif
 
+    /* Check for insn feature enabled.  */
+    if (!test_bit(insn->fac, s->features)) {
+        gen_program_exception(s, PGM_OPERATION);
+        return EXIT_NORETURN;
+    }
+
     /* Check for insn specification exceptions.  */
     if (insn->spec) {
         int spec = insn->spec, excp = 0, r;
@@ -5726,6 +5733,7 @@ void gen_intermediate_code(CPUS390XState *env, struct TranslationBlock *tb)
     }
 
     dc.tb = tb;
+    dc.features = cpu->model->features;
     dc.pc = pc_start;
     dc.cc_op = CC_OP_DYNAMIC;
     dc.ex_value = tb->cs_base;
-- 
2.9.4

  parent reply	other threads:[~2017-06-15  5:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15  5:53 [Qemu-devel] [PATCH 0/5] More s390x improvements Richard Henderson
2017-06-15  5:53 ` [Qemu-devel] [PATCH 1/5] target/s390x: Map existing FAC_* names to S390_FEAT_* names Richard Henderson
2017-06-15  5:53 ` Richard Henderson [this message]
2017-06-15  7:01   ` [Qemu-devel] [PATCH 2/5] target/s390x: Enforce instruction features Aurelien Jarno
2017-06-15 11:28     ` David Hildenbrand
2017-06-15 12:53       ` Aurelien Jarno
2017-06-15 13:10         ` David Hildenbrand
2017-06-15 20:55           ` Aurelien Jarno
2017-06-15  5:53 ` [Qemu-devel] [PATCH 3/5] target/s390x: change PSW_SHIFT_KEY Richard Henderson
2017-06-15  5:53 ` [Qemu-devel] [PATCH 4/5] target/s390x: implement mvcos instruction Richard Henderson
2017-06-15  5:53 ` [Qemu-devel] [PATCH 5/5] target/s390x: mark CSST, CSST2, FPSEH facilities as available Richard Henderson
2017-06-15  9:02   ` Thomas Huth
2017-06-15 15:55     ` Richard Henderson
2017-06-15 20:49   ` Aurelien Jarno
2017-06-15 21:10     ` Richard Henderson
2017-06-15 21:19       ` Aurelien Jarno
2017-06-15  7:51 ` [Qemu-devel] [PATCH 0/5] More s390x improvements no-reply
2017-06-15  7:59 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170615055356.20684-3-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=aurelien@aurel32.net \
    --cc=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).