qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Pavel Butsykin <pbutsykin@virtuozzo.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function
Date: Thu, 15 Jun 2017 17:38:11 +0100	[thread overview]
Message-ID: <20170615163813.7255-4-stefanha@redhat.com> (raw)
In-Reply-To: <20170615163813.7255-1-stefanha@redhat.com>

Avoid duplicating the QEMU command-line.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 tests/qemu-iotests/068 | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/tests/qemu-iotests/068 b/tests/qemu-iotests/068
index 9c1687d..653e23c 100755
--- a/tests/qemu-iotests/068
+++ b/tests/qemu-iotests/068
@@ -59,14 +59,17 @@ case "$QEMU_DEFAULT_MACHINE" in
       ;;
 esac
 
-# Give qemu some time to boot before saving the VM state
-bash -c 'sleep 1; echo -e "savevm 0\nquit"' |\
+_qemu()
+{
     $QEMU $platform_parm -nographic -monitor stdio -serial none -hda "$TEST_IMG" |\
+          "$@" |\
     _filter_qemu | _filter_hmp
+}
+
+# Give qemu some time to boot before saving the VM state
+bash -c 'sleep 1; echo -e "savevm 0\nquit"' | _qemu
 # Now try to continue from that VM state (this should just work)
-echo quit |\
-    $QEMU $platform_parm -nographic -monitor stdio -serial none -hda "$TEST_IMG" -loadvm 0 |\
-    _filter_qemu | _filter_hmp
+echo quit | _qemu -loadvm 0
 
 # success, all done
 echo "*** done"
-- 
2.9.4

  parent reply	other threads:[~2017-06-15 16:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15 16:38 [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!) Stefan Hajnoczi
2017-06-15 16:38 ` [Qemu-devel] [PATCH 1/5] virtio-pci: use ioeventfd even when KVM is disabled Stefan Hajnoczi
2017-06-16  3:26   ` Michael S. Tsirkin
2017-06-16  9:13     ` Stefan Hajnoczi
2017-06-16 14:12   ` Michael S. Tsirkin
2017-06-19 12:23     ` Stefan Hajnoczi
2017-06-27  8:43   ` Fam Zheng
2017-06-27 11:07     ` Kevin Wolf
2017-06-28 12:17       ` Stefan Hajnoczi
2017-06-15 16:38 ` [Qemu-devel] [PATCH 2/5] migration: hold AioContext lock for loadvm qemu_fclose() Stefan Hajnoczi
2017-06-15 16:38 ` Stefan Hajnoczi [this message]
2017-06-19 12:47   ` [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function Kevin Wolf
2017-06-27 11:40   ` Eric Blake
2017-06-27 11:42     ` Eric Blake
2017-06-28 12:13     ` Stefan Hajnoczi
2017-06-28 12:50       ` Eric Blake
2017-06-28 12:57     ` Kevin Wolf
2017-06-28 14:02       ` Eric Blake
2017-06-28 14:07         ` Kevin Wolf
2017-06-15 16:38 ` [Qemu-devel] [PATCH 4/5] qemu-iotests: 068: use -drive/-device instead of -hda Stefan Hajnoczi
2017-06-15 16:38 ` [Qemu-devel] [PATCH 5/5] qemu-iotests: 068: test iothread mode Stefan Hajnoczi
2017-06-15 16:42 ` [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!) Stefan Hajnoczi
2017-06-19 12:26 ` Pavel Butsykin
2017-07-05 12:55   ` Stefan Hajnoczi
2017-07-05 14:04     ` Pavel Butsykin
2017-06-19 12:55 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170615163813.7255-4-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbutsykin@virtuozzo.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).