From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] virtio-blk: trace vdev so devices can be distinguished
Date: Fri, 16 Jun 2017 10:04:10 +0100 [thread overview]
Message-ID: <20170616090410.GC31462@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170614092930.11234-1-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On Wed, Jun 14, 2017 at 10:29:30AM +0100, Stefan Hajnoczi wrote:
> It is hard to analyze trace logs with multiple virtio-blk devices
> because none of the trace events include the VirtIODevice *vdev.
>
> This patch adds vdev so it's clear which device a request is associated
> with.
>
> I considered using VirtIOBlock *s instead but VirtIODevice *vdev is more
> general and may be correlated with generic virtio trace events like
> virtio_set_status.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/block/virtio-blk.c | 12 +++++++-----
> hw/block/trace-events | 10 +++++-----
> 2 files changed, 12 insertions(+), 10 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2017-06-16 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 9:29 [Qemu-devel] [PATCH] virtio-blk: trace vdev so devices can be distinguished Stefan Hajnoczi
2017-06-14 10:08 ` no-reply
2017-06-16 0:28 ` Fam Zheng
2017-06-16 9:04 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616090410.GC31462@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).