From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLnrb-0006LB-BS for qemu-devel@nongnu.org; Fri, 16 Jun 2017 05:48:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dLnra-0002iU-EG for qemu-devel@nongnu.org; Fri, 16 Jun 2017 05:48:23 -0400 Date: Fri, 16 Jun 2017 10:48:09 +0100 From: "Daniel P. Berrange" Message-ID: <20170616094809.GC25765@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170615195209.17720-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170615195209.17720-1-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH] nbd: fix NBD over TLS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-stable@nongnu.org On Thu, Jun 15, 2017 at 09:52:09PM +0200, Paolo Bonzini wrote: > When attaching the NBD QIOChannel to an AioContext, the TLS channel should > be used, not the underlying socket channel. This is because, trivially, > the TLS channel will be the one that we read/write to and thus the one > that will get the qio_channel_yield() call. > > Fixes: ff82911cd3f69f028f2537825c9720ff78bc3f19 > Cc: qemu-stable@nongnu.org > Cc: Daniel P. Berrange > Signed-off-by: Paolo Bonzini > --- > block/nbd-client.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrange Tested-by: Daniel P. Berrange Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|