From: "Emilio G. Cota" <cota@braap.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, "Richard Henderson" <rth@twiddle.net>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael Walle" <michael@walle.cc>,
"Laurent Vivier" <laurent@vivier.eu>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Yongbok Kim" <yongbok.kim@imgtec.com>,
"Anthony Green" <green@moxielogic.com>,
"Chris Wulff" <crwulff@gmail.com>, "Marek Vasut" <marex@denx.de>,
"Stafford Horne" <shorne@gmail.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Alexander Graf" <agraf@suse.de>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Guan Xuetao" <gxt@mprc.pku.edu.cn>,
"Max Filippov" <jcmvbkbc@gmail.com>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
"Lluís Vilanova" <vilanova@ac.upc.edu>
Subject: Re: [Qemu-devel] [PATCH 2/2] gen-icount: pass cpu_env as a parameter to gen_* inlines
Date: Fri, 16 Jun 2017 14:50:56 -0400 [thread overview]
Message-ID: <20170616185056.GA3055@flamenco> (raw)
In-Reply-To: <df6ef6c7-6bb5-a509-5e8e-66757598b11f@redhat.com>
On Fri, Jun 16, 2017 at 10:32:14 +0200, Paolo Bonzini wrote:
> On 16/06/2017 01:04, Emilio G. Cota wrote:
> > va = dest_gpr(ctx, ra);
> > if (ctx->tb->cflags & CF_USE_ICOUNT) {
> > - gen_io_start();
> > + gen_io_start(cpu_env);
> > gen_helper_load_pcc(va, cpu_env);
> > - gen_io_end();
> > + gen_io_start(cpu_env);
>
> Careful, looks like a cut-and-paste issue here.
Ouch, messed up the regex there -- thanks.
Fixed in the upcoming v2, which doesn't need to go through all this churn
and instead takes the value from tcg_ctx as Richard pointed out.
E.
next prev parent reply other threads:[~2017-06-16 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 23:04 [Qemu-devel] [PATCH 1/2] gen-icount: add missing inline to gen_tb_end Emilio G. Cota
2017-06-15 23:04 ` [Qemu-devel] [PATCH 2/2] gen-icount: pass cpu_env as a parameter to gen_* inlines Emilio G. Cota
2017-06-16 2:54 ` Richard Henderson
2017-06-16 8:32 ` Paolo Bonzini
2017-06-16 18:50 ` Emilio G. Cota [this message]
2017-06-16 2:54 ` [Qemu-devel] [PATCH 1/2] gen-icount: add missing inline to gen_tb_end Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616185056.GA3055@flamenco \
--to=cota@braap.org \
--cc=agraf@suse.de \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=crwulff@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=green@moxielogic.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=laurent@vivier.eu \
--cc=marex@denx.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=shorne@gmail.com \
--cc=vilanova@ac.upc.edu \
--cc=yongbok.kim@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).