From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] block: qobject_is_equal() in bdrv_reopen_prepare()
Date: Mon, 19 Jun 2017 16:10:10 +0200 [thread overview]
Message-ID: <20170619141010.GH6113@noname.redhat.com> (raw)
In-Reply-To: <20170614153102.9077-4-mreitz@redhat.com>
Am 14.06.2017 um 17:31 hat Max Reitz geschrieben:
> Currently, bdrv_reopen_prepare() assumes that all BDS options are
> strings. However, this is not the case if the BDS has been created
> through the json: pseudo-protocol or blockdev-add.
>
> Note that the user-invokable reopen command is an HMP command, so you
> can only specify strings there. Therefore, specifying a non-string
> option with the "same" value as it was when originally created will now
> return an error because the values are supposedly similar (and there is
> no way for the user to circumvent this but to just not specify the
> option again -- however, this is still strictly better than just
> crashing).
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2017-06-19 14:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 15:30 [Qemu-devel] [PATCH 0/4] block: Don't compare strings in bdrv_reopen_prepare() Max Reitz
2017-06-14 15:30 ` [Qemu-devel] [PATCH 1/4] qapi/qnull: Add own header Max Reitz
2017-06-19 13:20 ` Kevin Wolf
2017-06-14 15:31 ` [Qemu-devel] [PATCH 2/4] qapi: Add qobject_is_equal() Max Reitz
2017-06-19 13:55 ` Kevin Wolf
2017-06-19 14:59 ` Max Reitz
2017-06-14 15:31 ` [Qemu-devel] [PATCH 3/4] block: qobject_is_equal() in bdrv_reopen_prepare() Max Reitz
2017-06-19 14:10 ` Kevin Wolf [this message]
2017-06-14 15:31 ` [Qemu-devel] [PATCH 4/4] iotests: Add test for non-string option reopening Max Reitz
2017-06-19 14:14 ` Kevin Wolf
2017-06-14 16:20 ` [Qemu-devel] [PATCH 0/4] block: Don't compare strings in bdrv_reopen_prepare() no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619141010.GH6113@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).