qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Tobias Schramm <tobleminer@gmail.com>
To: qemu-devel@nongnu.org
Cc: aneesh.kumar@linux.vnet.ibm.com, groug@kaod.org,
	el13635@mail.ntua.gr, Tobias Schramm <tobleminer@gmail.com>
Subject: [Qemu-devel] [PATCH v4 0/1] 9pfs: local: Add support for custom fmode/dmode in 9ps mapped security modes
Date: Mon, 19 Jun 2017 16:28:47 +0200	[thread overview]
Message-ID: <20170619142848.14258-1-tobleminer@gmail.com> (raw)

Hi,

i've noticed that there is no way to control the permissions of newly created files and
folders on the host when using 9p in mapped security mode. This can be a big problem when
configuring permissions for access to such data for groups and via ACLs on the host.
Thus I added the options fmode and dmode to the fsdev and virtfs options that set the actual
permissions of newly created files and folders on the host.

This version of the patch fixes the back to front "mask" naming in the previous patches. I
always meant "mode" when actually writing "mask".

Also specifying fmode and dmode only has an effect in mapped security modes. Specifying it
in any other mode now throws an error.

Additionally I've switched fmode and dmode to QEMU_OPT_NUMBER because it handels octal input
just fine.

Also previous versions leaked a string with g_strdup if an error during parsing of fmode/dmode
occurred.

Thanks to Greg Kurz for pointing out most of the above issues to me.

Tobias Schramm

Tobias Schramm (1):
  Add support for custom fmode/dmode in 9ps mapped security modes

 fsdev/file-op-9p.h      |  4 ++++
 fsdev/qemu-fsdev-opts.c | 12 ++++++++++++
 hw/9pfs/9p-local.c      | 34 +++++++++++++++++++++++++---------
 hw/9pfs/9p.c            |  3 +++
 qemu-options.hx         | 20 ++++++++++++++++----
 5 files changed, 60 insertions(+), 13 deletions(-)

-- 
2.13.1

             reply	other threads:[~2017-06-19 14:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19 14:28 Tobias Schramm [this message]
2017-06-19 14:28 ` [Qemu-devel] [PATCH v4 1/1] 9pfs: local: Add support for custom fmode/dmode in 9ps mapped security modes Tobias Schramm
2017-06-19 19:20   ` Greg Kurz
2017-06-19 19:15 ` [Qemu-devel] [PATCH v4 0/1] " Greg Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170619142848.14258-1-tobleminer@gmail.com \
    --to=tobleminer@gmail.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=el13635@mail.ntua.gr \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).