From: "Daniel P. Berrange" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Fam Zheng <famz@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Kevin Wolf <kwolf@redhat.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Peter Xu <peterx@redhat.com>, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] migration: Fix race of image locking between src and dst
Date: Mon, 19 Jun 2017 16:28:58 +0100 [thread overview]
Message-ID: <20170619152858.GK2640@redhat.com> (raw)
In-Reply-To: <CAFEAcA8sFcma8nspaGE7Sx-72VUGGo491JKp+We2XwgDmGX18A@mail.gmail.com>
On Mon, Jun 19, 2017 at 04:27:53PM +0100, Peter Maydell wrote:
> On 19 June 2017 at 15:49, Daniel P. Berrange <berrange@redhat.com> wrote:
> > IIUC as well as fixing the race condition, you're also improving
> > error reporting by using qemu_file_set_error() which was not done
> > previously. Would be nice to mention that in the commit message
> > too if you respin for any other reason, but that's just a nit-pick
>
> I've added
> N.B. This commit includes a minor improvement to the error handling
> by using qemu_file_set_error().
>
> to the commit message -- is that OK or do you want to suggest a
> different wording?
That's fine with me.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-06-19 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 16:06 [Qemu-devel] [PATCH] migration: Fix race of image locking between src and dst Fam Zheng
2017-06-19 14:49 ` Daniel P. Berrange
2017-06-19 15:27 ` Peter Maydell
2017-06-19 15:28 ` Daniel P. Berrange [this message]
2017-06-19 15:26 ` Juan Quintela
2017-06-19 16:54 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619152858.GK2640@redhat.com \
--to=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).