From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, alistai@xilinx.com,
sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com
Subject: Re: [Qemu-devel] [PATCH v1 6/7] target-microblaze: dec_barrel: Add BSIFI
Date: Tue, 20 Jun 2017 20:02:19 +0200 [thread overview]
Message-ID: <20170620180219.GH4859@toto> (raw)
In-Reply-To: <bc8476c4-8070-c253-637f-9ce35e0d68ee@twiddle.net>
On Tue, Jun 20, 2017 at 10:48:22AM -0700, Richard Henderson wrote:
> On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote:
> >+ int width = imm_w - imm_s + 1;
> >+
> >+ if (width == 0 || imm_w <= imm_s) {
>
> The width == 0 check is redundant; the imm_w <= imm_s check is wrong. It
> should be <.
>
> If imm_w >= imm_s, as per the proper check, then width must be >= 1.
Right, will fix for v2.
Thanks!
Edgar
next prev parent reply other threads:[~2017-06-20 18:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 16:08 [Qemu-devel] [PATCH v1 0/7] target-microblaze: Add support for BSXFI Edgar E. Iglesias
2017-06-20 16:08 ` [Qemu-devel] [PATCH v1 1/7] target-microblaze: dec_barrel: Use bool instead of unsigned int Edgar E. Iglesias
2017-06-20 17:44 ` Richard Henderson
2017-06-20 16:08 ` [Qemu-devel] [PATCH v1 2/7] target-microblaze: dec_barrel: Use extract32 Edgar E. Iglesias
2017-06-20 17:45 ` Richard Henderson
2017-06-20 16:09 ` [Qemu-devel] [PATCH v1 3/7] target-microblaze: dec_barrel: Add braces around if-statements Edgar E. Iglesias
2017-06-20 17:45 ` Richard Henderson
2017-06-20 16:09 ` [Qemu-devel] [PATCH v1 4/7] target-microblaze: dec_barrel: Plug TCG temp leak Edgar E. Iglesias
2017-06-20 17:45 ` Richard Henderson
2017-06-20 16:09 ` [Qemu-devel] [PATCH v1 5/7] target-microblaze: dec_barrel: Add BSEFI Edgar E. Iglesias
2017-06-20 17:43 ` Richard Henderson
2017-06-20 16:09 ` [Qemu-devel] [PATCH v1 6/7] target-microblaze: dec_barrel: Add BSIFI Edgar E. Iglesias
2017-06-20 17:48 ` Richard Henderson
2017-06-20 18:02 ` Edgar E. Iglesias [this message]
2017-06-20 16:09 ` [Qemu-devel] [PATCH v1 7/7] target-microblaze: Add CPU version 10.0 Edgar E. Iglesias
2017-06-20 18:04 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620180219.GH4859@toto \
--to=edgar.iglesias@gmail.com \
--cc=alistai@xilinx.com \
--cc=edgar.iglesias@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sai.pavan.boddu@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).