From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com,
kwolf@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/5] Create setup/cleanup methods for migration incoming side
Date: Wed, 21 Jun 2017 12:20:00 +0200 [thread overview]
Message-ID: <20170621102005.18701-1-quintela@redhat.com> (raw)
Hi
Changes from v2:
- rename htab_cleanup htab_save_cleanup (dave)
- loaded_data was needed because caller can need it (dave)
- improve error message (dave)
Please, review.
[v2]
- Kevin detected that I didn't called load_cleanup(), fix it.
- Be consistent and change the naming of the functions so they are all:
qemu_savevm_state_* or qemu_loadvm_state*
- the traces still used the all names of _begin, instead of _setup,
fix that.
Please, review.
Later, Juan.
PD: Yes, now that the includes are internal, we coauld rename
"qemu_savevm_state_" to something shorter, like `savevm_". The
same for the loadvm counterparts. But I am not doing any such
changes soon, too much churn for so little gain.
[v1]
This series make:
- use of cleanup/save methods generic, not only for save_live methods
- create the equivalent methods for the load side (load_setup/cleanup)
- Make ram use this methods to see how/when they are used.
Stefan, Kevin, this were the methods that you asked for the block.c
migration, right? Please, comment if they are enough for you.
Juan Quintela (5):
migration: Rename save_live_setup() to save_setup()
migration: Rename cleanup() to save_cleanup()
migration: Create load_setup()/cleanup() methods
migration: Convert ram to use new load_setup()/load_cleanup()
migration: Make compression_threads use save/load_setup/cleanup()
hw/ppc/spapr.c | 6 ++---
include/migration/register.h | 6 +++--
migration/block.c | 4 +--
migration/colo.c | 2 +-
migration/migration.c | 10 +------
migration/ram.c | 63 +++++++++++++++++++++++++++++++-------------
migration/ram.h | 6 -----
migration/savevm.c | 60 +++++++++++++++++++++++++++++++++++------
migration/savevm.h | 2 +-
migration/trace-events | 4 ++-
10 files changed, 112 insertions(+), 51 deletions(-)
--
2.9.4
next reply other threads:[~2017-06-21 10:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 10:20 Juan Quintela [this message]
2017-06-21 10:20 ` [Qemu-devel] [PATCH v3 1/5] migration: Rename save_live_setup() to save_setup() Juan Quintela
2017-06-21 10:20 ` [Qemu-devel] [PATCH v3 2/5] migration: Rename cleanup() to save_cleanup() Juan Quintela
2017-06-21 10:20 ` [Qemu-devel] [PATCH v3 3/5] migration: Create load_setup()/cleanup() methods Juan Quintela
2017-06-22 10:33 ` Dr. David Alan Gilbert
2017-06-28 8:17 ` Juan Quintela
2017-06-21 10:20 ` [Qemu-devel] [PATCH v3 4/5] migration: Convert ram to use new load_setup()/load_cleanup() Juan Quintela
2017-06-21 18:57 ` Dr. David Alan Gilbert
2017-06-21 10:20 ` [Qemu-devel] [PATCH v3 5/5] migration: Make compression_threads use save/load_setup/cleanup() Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621102005.18701-1-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).