From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dNeeb-0006oV-Rm for qemu-devel@nongnu.org; Wed, 21 Jun 2017 08:22:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dNeeX-0008HR-UF for qemu-devel@nongnu.org; Wed, 21 Jun 2017 08:22:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45326) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dNeeX-0008H8-Nx for qemu-devel@nongnu.org; Wed, 21 Jun 2017 08:22:33 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D65D07F6B6 for ; Wed, 21 Jun 2017 12:22:31 +0000 (UTC) From: Gerd Hoffmann Date: Wed, 21 Jun 2017 14:22:34 +0200 Message-Id: <20170621122234.12751-1-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH] sdl2: add assert to make coverity happy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann There is a loop a few lines up counting consoles and setting sdl2_num_outputs accordingly, so con ptr can't be NULL there. Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index f76ee1081f..53dd447fd2 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -804,6 +804,7 @@ void sdl_display_init(DisplayState *ds, int full_screen, int no_frame) sdl2_console = g_new0(struct sdl2_console, sdl2_num_outputs); for (i = 0; i < sdl2_num_outputs; i++) { QemuConsole *con = qemu_console_lookup_by_index(i); + assert(con != NULL); if (!qemu_console_is_graphic(con)) { sdl2_console[i].hidden = true; } -- 2.9.3