* [Qemu-devel] [PATCH] iotests: 181 does not work for all formats
@ 2017-06-21 13:11 Max Reitz
2017-06-26 19:17 ` [Qemu-devel] [Qemu-block] " John Snow
0 siblings, 1 reply; 3+ messages in thread
From: Max Reitz @ 2017-06-21 13:11 UTC (permalink / raw)
To: qemu-block; +Cc: qemu-devel, Max Reitz, Kevin Wolf
Test 181 only works for formats which support live migration (naturally,
as it is a live migration test). Disable it for all formats which do
not.
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
tests/qemu-iotests/181 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/181 b/tests/qemu-iotests/181
index e969a2a..f73ad5a 100755
--- a/tests/qemu-iotests/181
+++ b/tests/qemu-iotests/181
@@ -43,6 +43,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
. ./common.qemu
_supported_fmt generic
+# Formats that do not support live migration
+_unsupported_fmt qcow vdi vhdx vmdk vpc vvfat
_supported_proto generic
_supported_os Linux
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: 181 does not work for all formats
2017-06-21 13:11 [Qemu-devel] [PATCH] iotests: 181 does not work for all formats Max Reitz
@ 2017-06-26 19:17 ` John Snow
2017-06-26 19:23 ` Max Reitz
0 siblings, 1 reply; 3+ messages in thread
From: John Snow @ 2017-06-26 19:17 UTC (permalink / raw)
To: Max Reitz, qemu-block; +Cc: Kevin Wolf, qemu-devel
On 06/21/2017 09:11 AM, Max Reitz wrote:
> Test 181 only works for formats which support live migration (naturally,
> as it is a live migration test). Disable it for all formats which do
> not.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/181 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qemu-iotests/181 b/tests/qemu-iotests/181
> index e969a2a..f73ad5a 100755
> --- a/tests/qemu-iotests/181
> +++ b/tests/qemu-iotests/181
> @@ -43,6 +43,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
> . ./common.qemu
>
> _supported_fmt generic
> +# Formats that do not support live migration
> +_unsupported_fmt qcow vdi vhdx vmdk vpc vvfat
> _supported_proto generic
> _supported_os Linux
>
>
Does this come up elsewhere in iotests? I guess not often enough to
justify some macro like formats_unmigratable.
Eh.
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: 181 does not work for all formats
2017-06-26 19:17 ` [Qemu-devel] [Qemu-block] " John Snow
@ 2017-06-26 19:23 ` Max Reitz
0 siblings, 0 replies; 3+ messages in thread
From: Max Reitz @ 2017-06-26 19:23 UTC (permalink / raw)
To: John Snow, qemu-block; +Cc: Kevin Wolf, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]
On 2017-06-26 21:17, John Snow wrote:
>
>
> On 06/21/2017 09:11 AM, Max Reitz wrote:
>> Test 181 only works for formats which support live migration (naturally,
>> as it is a live migration test). Disable it for all formats which do
>> not.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>> tests/qemu-iotests/181 | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/qemu-iotests/181 b/tests/qemu-iotests/181
>> index e969a2a..f73ad5a 100755
>> --- a/tests/qemu-iotests/181
>> +++ b/tests/qemu-iotests/181
>> @@ -43,6 +43,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>> . ./common.qemu
>>
>> _supported_fmt generic
>> +# Formats that do not support live migration
>> +_unsupported_fmt qcow vdi vhdx vmdk vpc vvfat
>> _supported_proto generic
>> _supported_os Linux
>>
>>
>
> Does this come up elsewhere in iotests? I guess not often enough to
> justify some macro like formats_unmigratable.
Well, formats_no_backing might happen more often...
> Eh.
Don't want to volunteer? :-)
> Reviewed-by: John Snow <jsnow@redhat.com>
Thanks!
Aaand applied to my block branch.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 498 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-26 19:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-21 13:11 [Qemu-devel] [PATCH] iotests: 181 does not work for all formats Max Reitz
2017-06-26 19:17 ` [Qemu-devel] [Qemu-block] " John Snow
2017-06-26 19:23 ` Max Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).