From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dO5uk-0006Vs-GH for qemu-devel@nongnu.org; Thu, 22 Jun 2017 13:29:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dO5uh-0003Ex-Ba for qemu-devel@nongnu.org; Thu, 22 Jun 2017 13:29:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44584) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dO5uh-0003Do-5B for qemu-devel@nongnu.org; Thu, 22 Jun 2017 13:29:03 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 261DF30AF5B for ; Thu, 22 Jun 2017 17:29:02 +0000 (UTC) Date: Thu, 22 Jun 2017 14:28:52 -0300 From: Eduardo Habkost Message-ID: <20170622172852.GC20956@localhost.localdomain> References: <1498031528-1990-1-git-send-email-peterx@redhat.com> <1498031528-1990-3-git-send-email-peterx@redhat.com> <20170621122311.GC3928@thinpad.lan.raisama.net> <20170622042530.GB3936@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170622042530.GB3936@pxdev.xzpeter.org> Subject: Re: [Qemu-devel] [PATCH v4 02/10] accel: introduce AccelClass.global_props List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Laurent Vivier , Eric Blake , Markus Armbruster , Juan Quintela , "Dr . David Alan Gilbert" On Thu, Jun 22, 2017 at 12:25:30PM +0800, Peter Xu wrote: > On Wed, Jun 21, 2017 at 09:23:11AM -0300, Eduardo Habkost wrote: > > On Wed, Jun 21, 2017 at 03:52:00PM +0800, Peter Xu wrote: [...] > > > diff --git a/vl.c b/vl.c > > > index 59fea15..4452d7a 100644 > > > --- a/vl.c > > > +++ b/vl.c > > > @@ -4571,6 +4571,7 @@ int main(int argc, char **argv, char **envp) > > > exit (i == 1 ? 1 : 0); > > > } > > > > > > > I suggest a comment here warning about global property > > registration ordering. e.g.: > > > > /* > > * Ordering of global property registration matters: > > * - machine compat_props should override accelerator-specific > > * globals. > > * - user-provided globals (-global, and global properties > > * derived from other command-line options like -cpu) should > > * override machine compat_props and accelerator-specific > > * globals. > > */ > > I have a standalone patch (next one) to unify these three places and > added some comment. Would that suite? Sorry, I didn't see that patch when I was reviewing this one. It looks good to me. Thanks! -- Eduardo