qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 04/31] vhost: use QEMU_ALIGN_DOWN
Date: Thu, 22 Jun 2017 21:49:45 +0300	[thread overview]
Message-ID: <20170622214937-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20170622124204.19407-5-marcandre.lureau@redhat.com>

On Thu, Jun 22, 2017 at 02:41:37PM +0200, Marc-André Lureau wrote:
> I used the clang-tidy qemu-round check to generate the fix:
> https://github.com/elmarco/clang-tools-extra
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/virtio/vhost.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 6eddb099b0..0049a2c0b3 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -70,7 +70,7 @@ static void vhost_dev_sync_region(struct vhost_dev *dev,
>      uint64_t end = MIN(mlast, rlast);
>      vhost_log_chunk_t *from = log + start / VHOST_LOG_CHUNK;
>      vhost_log_chunk_t *to = log + end / VHOST_LOG_CHUNK + 1;
> -    uint64_t addr = (start / VHOST_LOG_CHUNK) * VHOST_LOG_CHUNK;
> +    uint64_t addr = QEMU_ALIGN_DOWN(start, VHOST_LOG_CHUNK);
>  
>      if (end < start) {
>          return;
> -- 
> 2.13.1.395.gf7b71de06

  reply	other threads:[~2017-06-22 18:49 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 12:41 [Qemu-devel] [PATCH 00/31] Refactoring with clang-tidy Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 01/31] i386: use ROUND_UP macro Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 02/31] vnc: use QEMU_ALIGN_DOWN Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 03/31] vhdx: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 04/31] vhost: " Marc-André Lureau
2017-06-22 18:49   ` Michael S. Tsirkin [this message]
2017-06-22 12:41 ` [Qemu-devel] [PATCH 05/31] i8254: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 06/31] pcspk: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 07/31] dmg: use DIV_ROUND_UP Marc-André Lureau
2017-06-23  9:56   ` Stefan Hajnoczi
2017-06-22 12:41 ` [Qemu-devel] [PATCH 08/31] qcow2: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 09/31] vpc: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 10/31] vvfat: " Marc-André Lureau
2017-07-03 11:38   ` [Qemu-devel] [Qemu-block] " Eric Blake
2017-06-22 12:41 ` [Qemu-devel] [PATCH 11/31] vnc: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 12/31] slirp: " Marc-André Lureau
2017-06-23  0:19   ` Samuel Thibault
2017-06-22 12:41 ` [Qemu-devel] [PATCH 13/31] ui: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 14/31] vga: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 15/31] virtio-gpu: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 16/31] monitor: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 17/31] console: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 18/31] virtio-serial: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 19/31] piix: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 20/31] q35: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 21/31] usb-hub: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 22/31] msix: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 23/31] ppc: " Marc-André Lureau
2017-07-02  3:04   ` David Gibson
2017-06-22 12:41 ` [Qemu-devel] [PATCH 24/31] i386/dump: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 25/31] kvm: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 26/31] decnumber: " Marc-André Lureau
2017-06-22 12:42 ` [Qemu-devel] [PATCH 27/31] i386: introduce ELF_NOTE_SIZE macro Marc-André Lureau
2017-06-22 12:42 ` [Qemu-devel] [PATCH 28/31] 9pfs: replace g_malloc()+memcpy() with g_memdup() Marc-André Lureau
2017-06-22 13:08   ` Greg Kurz
2017-06-22 12:42 ` [Qemu-devel] [PATCH 29/31] i386: " Marc-André Lureau
2017-06-22 12:42 ` [Qemu-devel] [PATCH 30/31] test-iov: " Marc-André Lureau
2017-06-22 12:42 ` [Qemu-devel] [PATCH 31/31] eepro100: " Marc-André Lureau
2017-06-22 13:09   ` Stefan Weil
2017-06-23  8:46     ` Jason Wang
2017-06-22 12:59 ` [Qemu-devel] [PATCH 00/31] Refactoring with clang-tidy Peter Maydell
2017-06-22 13:54 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170622214937-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).