From: Kashyap Chamarthy <kchamart@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org,
stephen@that.guru, armbru@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] live-block-ops.txt: Rename, rewrite, and improve it
Date: Fri, 23 Jun 2017 10:15:38 +0200 [thread overview]
Message-ID: <20170623081538.nqaxrylinzgg37il@eukaryote> (raw)
In-Reply-To: <3e638f0a-49f8-6fd0-04eb-12904768d571@redhat.com>
On Thu, Jun 22, 2017 at 10:13:03AM -0400, John Snow wrote:
> On 06/22/2017 04:56 AM, Kashyap Chamarthy wrote:
> > On Wed, Jun 21, 2017 at 06:49:02PM -0400, John Snow wrote:
[...]
> > Yes, I was thinking of this, too -- just link to the 'bitmaps' document.
> >
> > A quick side question here: Since upstream QEMU is converging onto
> > Sphinx, and rST, hope you mind if I convert docs/devel/bitmaps.md into
> > rST at somepoint, for consistency's sake. I'll file a separate review,
> > anyway for that. In the long term, all / most other documents would
> > also be converted.
> >
>
> Of course not. I chose bitmaps.md so that it would be nice to view from
> the github interface while remaining nice to read in plaintext, but feel
> free to convert it if we actually do standardize on Sphinx/rST.
>
> If you can make the generated output look prettier than the github
> rendering of the markdown I'll ACK it ;)
:-) Here's a sneak-peak (don't miss the index to your left hand side):
https://kashyapc.fedorapeople.org/v3-QEMU-Docs/_build/html/docs/bitmaps.html
Compare that with the GitHub rendering:
https://github.com/qemu/qemu/blob/master/docs/devel/bitmaps.md
And, here's the source (in reStructuredText, despite the ".txt"
extension) for the 'bitmaps' doc (I made tiny styling changes):
https://kashyapc.fedorapeople.org/v3-QEMU-Docs/_build/html/_sources/docs/bitmaps.txt
> > Yes, I fully agree with your suggestion. I will simply link to the
> > detailed document you wrote, which I was thinking of anyhow.
> >
> > Thanks for your comments!
> >
> Sure. You could perhaps mention the different sync modes, including top,
> none, full and incremental and urge readers to check out the bitmaps
> document for detailed workings of the incremental mode.
Yeah, good point. I'll make that edit in v2.
--
/kashyap
next prev parent reply other threads:[~2017-06-23 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 10:19 [Qemu-devel] [PATCH v3] live-block-ops.txt: Rename, rewrite, and improve it Kashyap Chamarthy
2017-06-21 22:49 ` John Snow
2017-06-22 8:56 ` Kashyap Chamarthy
2017-06-22 14:13 ` John Snow
2017-06-23 8:15 ` Kashyap Chamarthy [this message]
2017-06-23 18:53 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623081538.nqaxrylinzgg37il@eukaryote \
--to=kchamart@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stephen@that.guru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).